Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433) #1645

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Aug 22, 2022

This reverts commit e7dfa19.

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

  • found critical regression
  • revert above PR commit

Please check the diff between this PR branch and the branch of one step before the PR #1433. (a514ec1)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3
Copy link
Contributor

I checked no change is applied to stop line.
image

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1645 (22c6b40) into main (1115898) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
- Coverage   10.68%   10.64%   -0.04%     
==========================================
  Files        1109     1109              
  Lines       78629    78858     +229     
  Branches    18592    18720     +128     
==========================================
  Hits         8398     8398              
- Misses      61318    61534     +216     
- Partials     8913     8926      +13     
Flag Coverage Δ *Carryforward flag
differential 4.15% <0.00%> (?)
total 10.66% <0.00%> (ø) Carriedforward from 1115898

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planner/include/scene_module/stop_line/manager.hpp 0.00% <ø> (ø)
...y_planner/include/scene_module/stop_line/scene.hpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/debug.cpp 0.00% <0.00%> (ø)
...ity_planner/src/scene_module/stop_line/manager.cpp 0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/scene.cpp 0.00% <0.00%> (ø)
...vior_velocity_planner/include/utilization/util.hpp 0.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@satoshi-ota satoshi-ota changed the title revert "feat(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433)" Revert "feat(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433)" Aug 22, 2022
@satoshi-ota satoshi-ota changed the title Revert "feat(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433)" revert: "feat(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433)" Aug 22, 2022
@satoshi-ota satoshi-ota changed the title revert: "feat(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433)" revert:(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433) Aug 22, 2022
…distance (autowarefoundation#1433)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the revert/stop-line-module-hold-stop branch from 35c28c4 to 22c6b40 Compare August 22, 2022 07:17
@satoshi-ota satoshi-ota changed the title revert:(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433) revert(behavior_velocity_planner): keep stopping in hold stop margin distance (#1433) Aug 22, 2022
@satoshi-ota
Copy link
Contributor Author

fix commit log

@satoshi-ota
Copy link
Contributor Author

@taikitanaka3

simplescreenrecorder-2022-08-22_16.32.04.mp4

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) August 22, 2022 07:42
@taikitanaka3 taikitanaka3 merged commit 6f7db46 into autowarefoundation:main Aug 22, 2022
@satoshi-ota satoshi-ota deleted the revert/stop-line-module-hold-stop branch August 22, 2022 08:06
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…distance (tier4#1433) (autowarefoundation#1645)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…distance (tier4#1433) (autowarefoundation#1645)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…distance (tier4#1433) (autowarefoundation#1645)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…distance (autowarefoundation#1433) (autowarefoundation#1645)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…distance (tier4#1433) (autowarefoundation#1645)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants