Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity): fixed missing initialization in merge_from_private module #1644

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 22, 2022

Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp

Description

Some of the parameters were not initialized in merge_from_private module.

Tests performed

Checked if the specified parameters are used.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ivate module

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1644 (1873dc6) into main (1115898) will decrease coverage by 0.28%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1644      +/-   ##
==========================================
- Coverage   10.68%   10.39%   -0.29%     
==========================================
  Files        1109     1103       -6     
  Lines       78629    74664    -3965     
  Branches    18592    19781    +1189     
==========================================
- Hits         8398     7765     -633     
+ Misses      61318    58125    -3193     
+ Partials     8913     8774     -139     
Flag Coverage Δ *Carryforward flag
differential 4.52% <0.00%> (?)
total 10.60% <0.00%> (-0.07%) ⬇️ Carriedforward from 1115898

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...d_api_msgs/srv/interface_version__type_support.cpp 0.00% <0.00%> (-54.55%) ⬇️
.../_autoware_ad_api_msgs_s.ep.rosidl_typesupport_c.c 0.00% <0.00%> (-47.46%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 0.00% <0.00%> (-32.72%) ⬇️
...s/srv/detail/interface_version__type_support_c.cpp 0.00% <0.00%> (-31.00%) ⬇️
...py/autoware_ad_api_msgs/srv/_interface_version_s.c 0.00% <0.00%> (-29.63%) ⬇️
... and 712 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin closed this Aug 22, 2022
@soblin soblin deleted the fix/merge-from-private-initialization branch August 22, 2022 17:31
@soblin soblin restored the fix/merge-from-private-initialization branch September 9, 2022 09:18
@soblin soblin reopened this Sep 9, 2022
@soblin soblin enabled auto-merge (squash) September 9, 2022 09:24
@soblin soblin merged commit 6e739b6 into autowarefoundation:main Sep 9, 2022
@soblin soblin deleted the fix/merge-from-private-initialization branch September 20, 2022 06:51
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ivate module (autowarefoundation#1644)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ivate module (autowarefoundation#1644)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ivate module (autowarefoundation#1644)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ivate module (autowarefoundation#1644)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to soblin/autoware.universe that referenced this pull request Dec 22, 2022
…ivate module (autowarefoundation#1644)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants