Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity): publish internal debug path #1635

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Aug 19, 2022

Description

  • publish internal behavior velocity path as a debug message.

image

To test this use planning debug tool trajectory analyzer

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 changed the title Feature/behavior velocity publish internal debug path feat(behavior_velocity): publish internal debug path Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #1635 (5f1057d) into main (020c6d8) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1635      +/-   ##
==========================================
- Coverage   10.68%   10.54%   -0.14%     
==========================================
  Files        1109     1102       -7     
  Lines       78600    72316    -6284     
  Branches    18547    18110     -437     
==========================================
- Hits         8398     7629     -769     
+ Misses      61341    56171    -5170     
+ Partials     8861     8516     -345     
Flag Coverage Δ *Carryforward flag
differential 4.64% <0.00%> (?)
total 10.59% <0.00%> (-0.08%) ⬇️ Carriedforward from 6001841

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
..._ad_api_msgs/msg/response_status__type_support.cpp 0.00% <0.00%> (-66.67%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
...d_api_msgs/srv/interface_version__type_support.cpp 0.00% <0.00%> (-54.55%) ⬇️
.../_autoware_ad_api_msgs_s.ep.rosidl_typesupport_c.c 0.00% <0.00%> (-47.46%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 0.00% <0.00%> (-32.72%) ⬇️
...s/srv/detail/interface_version__type_support_c.cpp 0.00% <0.00%> (-31.00%) ⬇️
...py/autoware_ad_api_msgs/srv/_interface_version_s.c 0.00% <0.00%> (-29.63%) ⬇️
... and 669 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the feature/behavior_velocity_publish_internal_debug_path branch from 59e177d to 5f1057d Compare August 21, 2022 12:09
@taikitanaka3 taikitanaka3 marked this pull request as ready for review August 21, 2022 12:12
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) August 22, 2022 01:40
@soblin
Copy link
Contributor

soblin commented Aug 22, 2022

LGTM! Thanks

@taikitanaka3 taikitanaka3 merged commit e5fde0b into autowarefoundation:main Aug 22, 2022
@taikitanaka3 taikitanaka3 deleted the feature/behavior_velocity_publish_internal_debug_path branch August 22, 2022 06:25
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ion#1635)

* feat(behavior_velocity): publish internal path as debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add debug internal scene module path

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velcoity, planning_debug_tools): add params for debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1635)

* feat(behavior_velocity): publish internal path as debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add debug internal scene module path

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velcoity, planning_debug_tools): add params for debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ion#1635)

* feat(behavior_velocity): publish internal path as debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add debug internal scene module path

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velcoity, planning_debug_tools): add params for debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ion#1635)

* feat(behavior_velocity): publish internal path as debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add debug internal scene module path

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velcoity, planning_debug_tools): add params for debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ion#1635)

* feat(behavior_velocity): publish internal path as debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velocity): add debug internal scene module path

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(behavior_velcoity, planning_debug_tools): add params for debug path

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants