Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(tier4_calibration_rviz_plugin): readability-identifier-naming #1618

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 18, 2022

Description

revert readability-identifier-naming with same reason as #1617

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from tkimura4 August 18, 2022 08:23
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1618 (47239d6) into main (219af03) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1618   +/-   ##
=======================================
  Coverage   10.76%   10.76%           
=======================================
  Files        1111     1111           
  Lines       78546    78546           
  Branches    18554    18554           
=======================================
  Hits         8459     8459           
  Misses      61226    61226           
  Partials     8861     8861           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.75% <0.00%> (ø) Carriedforward from 219af03

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...in/src/accel_brake_map_calibrator_button_panel.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I confirmed that AccelBrakeMapCalibrationButton worked.

@h-ohta h-ohta merged commit 7176ea5 into autowarefoundation:main Aug 18, 2022
@h-ohta h-ohta deleted the revert/tier4_calibration_rviz_plugin/readability-identifier-naming branch August 18, 2022 09:30
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants