fix(behavior_path_planner): fix turn signal logic in intersection

[rej55]

Signed-off-by: Fumiya Watanabe rej55.g@gmail.com

Description

Fix turn signal logic.
Before this change, if the turn_direction is straight, it finishes search turn direction due to the early return.
To fix it, I add the distance update in final step in the turn signal decider.

Related links

#1511

Tests performed

Tested in planning simulator.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #1519 (df8a9f6) into main (667bd0b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1519      +/-   ##
==========================================
- Coverage   10.61%   10.61%   -0.01%     
==========================================
  Files        1113     1113              
  Lines       78590    78592       +2     
  Branches    18420    18421       +1     
==========================================
  Hits         8342     8342              
- Misses      61522    61524       +2     
  Partials     8726     8726              

Flag	Coverage Δ		*Carryforward flag
differential	0.78% <0.00%> (?)
total	10.59% <0.00%> (ø)		Carriedforward from 667bd0b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../behavior_path_planner/src/turn_signal_decider.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tkimura4]

LGTM

2022-08-04-19-54-03.mp4