-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tier4_autoware_utils, obstacle_cruise_planner): add function to create deleted marker #1513
feat(tier4_autoware_utils, obstacle_cruise_planner): add function to create deleted marker #1513
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 10.36% 10.59% +0.22%
==========================================
Files 1135 1137 +2
Lines 79574 83467 +3893
Branches 18534 20857 +2323
==========================================
+ Hits 8251 8846 +595
- Misses 63122 65438 +2316
- Partials 8201 9183 +982
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No. This PR is the part of fix for #1116. |
…create deleted marker (autowarefoundation#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…create deleted marker (tier4#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…create deleted marker (tier4#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…create deleted marker (tier4#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…create deleted marker (autowarefoundation#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…create deleted marker (tier4#1513) * feat(tier4_autoware_utils): add function to create deleted marker Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * apply fix to obstacle_cruise_planner Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix bug Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Description
added a function to delete wall marker in tier4_autoware_utils, and applied it to obstacle_cruise_planner.
In the following video, with this PR, the stop red wall disappeared quickly once the object was removed (and the trajectory's color becomes green).
without this PR
https://user-images.githubusercontent.com/20228327/182741991-fd301c65-3890-4fbb-854f-844c07d8c281.mp4
with this PR
https://user-images.githubusercontent.com/20228327/182741970-481211de-2189-4040-8501-e68fc0527888.mp4
If you want to confirm if this works,
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.