Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils, obstacle_cruise_planner): add function to create deleted marker #1513

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Aug 4, 2022

Description

added a function to delete wall marker in tier4_autoware_utils, and applied it to obstacle_cruise_planner.

In the following video, with this PR, the stop red wall disappeared quickly once the object was removed (and the trajectory's color becomes green).

without this PR
https://user-images.githubusercontent.com/20228327/182741991-fd301c65-3890-4fbb-854f-844c07d8c281.mp4

with this PR
https://user-images.githubusercontent.com/20228327/182741970-481211de-2189-4040-8501-e68fc0527888.mp4

If you want to confirm if this works,

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review August 4, 2022 00:19
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 changed the title feat(tier4_autoware_utils): add function to create deleted marker feat(tier4_autoware_utils, obstacle_cruise_planner): add function to create deleted marker Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1513 (daf23d2) into main (05f6a6b) will increase coverage by 0.22%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   10.36%   10.59%   +0.22%     
==========================================
  Files        1135     1137       +2     
  Lines       79574    83467    +3893     
  Branches    18534    20857    +2323     
==========================================
+ Hits         8251     8846     +595     
- Misses      63122    65438    +2316     
- Partials     8201     9183     +982     
Flag Coverage Δ *Carryforward flag
differential 11.48% <0.00%> (?)
total 10.35% <0.00%> (ø) Carriedforward from 05f6a6b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
common/motion_utils/src/marker/marker_helper.cpp 0.00% <0.00%> (ø)
...lanner/src/pid_based_planner/pid_based_planner.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...ace_planning_algorithms/src/abstract_algorithm.cpp 76.53% <0.00%> (-1.40%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 0.81% <0.00%> (-0.24%) ⬇️
planning/obstacle_stop_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/route_handler/src/route_handler.cpp 0.00% <0.00%> (ø)
planning/obstacle_cruise_planner/src/node.cpp 0.00% <0.00%> (ø)
planning/motion_velocity_smoother/src/resample.cpp 0.00% <0.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit bbecb7f into autowarefoundation:main Aug 5, 2022
@takayuki5168 takayuki5168 deleted the feat/delete-marker-utils branch August 5, 2022 00:39
@h-ohta
Copy link
Contributor

h-ohta commented Aug 5, 2022

#1116

@taikitanaka3
Copy link
Contributor

@h-ohta
Could you close #1116 if there is no any more problems?

@h-ohta
Copy link
Contributor

h-ohta commented Aug 5, 2022

No. This PR is the part of fix for #1116.

HaoruXue pushed a commit to HaoruXue/autoware.universe that referenced this pull request Aug 10, 2022
…create deleted marker (autowarefoundation#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…create deleted marker (tier4#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…create deleted marker (tier4#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…create deleted marker (tier4#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…create deleted marker (autowarefoundation#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…create deleted marker (tier4#1513)

* feat(tier4_autoware_utils): add function to create deleted marker

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* apply fix to obstacle_cruise_planner

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix bug

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants