Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behavior_velocity_planner, obstacle_stop_planner): add description of redundant restart prevention #1507

Conversation

satoshi-ota
Copy link
Contributor

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota added the type:documentation Creating or refining documentation. (auto-assigned) label Aug 3, 2022
@satoshi-ota satoshi-ota force-pushed the docs/update-readme-restart-prevention branch from fc6feff to 274ebe4 Compare August 3, 2022 07:44
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the docs/update-readme-restart-prevention branch from 274ebe4 to 77c14c8 Compare August 3, 2022 07:51
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1507 (17c3d15) into main (3f25602) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1507      +/-   ##
==========================================
+ Coverage   10.37%   10.39%   +0.02%     
==========================================
  Files        1136     1134       -2     
  Lines       79480    79312     -168     
  Branches    18483    18483              
==========================================
  Hits         8245     8245              
+ Misses      63032    62864     -168     
  Partials     8203     8203              
Flag Coverage Δ *Carryforward flag
differential 3.92% <ø> (?)
total 10.38% <ø> (+0.02%) ⬆️ Carriedforward from 77c14c8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/cuda_utils.hpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...on/lidar_apollo_instance_segmentation/src/node.cpp 0.00% <0.00%> (ø)
...on/traffic_light_classifier/src/cnn_classifier.cpp 0.00% <0.00%> (ø)
...on/traffic_light_ssd_fine_detector/src/nodelet.cpp 0.00% <0.00%> (ø)
...lidar_centerpoint/lib/network/tensorrt_wrapper.cpp 0.00% <0.00%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f25602...17c3d15. Read the comment docs.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota changed the title docs(behavior_velocity_planner): update README docs(behavior_velocity_planner, obstacle_stop_planner): add description of redundant restart prevention Aug 3, 2022
@satoshi-ota satoshi-ota marked this pull request as ready for review August 3, 2022 08:08
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TakaHoribe TakaHoribe merged commit 965c0be into autowarefoundation:main Aug 5, 2022
@satoshi-ota satoshi-ota deleted the docs/update-readme-restart-prevention branch August 5, 2022 02:44
HaoruXue pushed a commit to HaoruXue/autoware.universe that referenced this pull request Aug 10, 2022
…on of redundant restart prevention (autowarefoundation#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…on of redundant restart prevention (tier4#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…on of redundant restart prevention (tier4#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…on of redundant restart prevention (tier4#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…on of redundant restart prevention (autowarefoundation#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…on of redundant restart prevention (tier4#1507)

* docs(behavior_velocity_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(obstacle_stop_planner): update README

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Sep 4, 2024
autowarefoundation#1507)

fix memory leak

Signed-off-by: Yukihito Saito <yukky.saito@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants