Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_velocity_planner): use-motion-utils #1493

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Aug 2, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Use resampling functions from motion utils instead of using original functions.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1493 (5726e79) into main (08d7a12) will increase coverage by 0.00%.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##             main    #1493   +/-   ##
=======================================
  Coverage   10.37%   10.38%           
=======================================
  Files        1135     1135           
  Lines       79575    79630   +55     
  Branches    18549    18604   +55     
=======================================
+ Hits         8254     8267   +13     
- Misses      63107    63147   +40     
- Partials     8214     8216    +2     
Flag Coverage Δ *Carryforward flag
differential 4.63% <20.00%> (?)
total 10.35% <25.00%> (ø) Carriedforward from 79ede01

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ocity_planner/src/utilization/path_utilization.cpp 19.12% <33.33%> (+1.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08d7a12...5726e79. Read the comment docs.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 changed the title feat(obstacle_velocity_planner): use-motion-utils feat(behavior_velocity_planner): use-motion-utils Aug 2, 2022
Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR compare

before
image

after
image

LGTM

@purewater0901 purewater0901 merged commit 485702e into autowarefoundation:main Aug 2, 2022
@purewater0901 purewater0901 deleted the feat/behavior-velocity-resample branch August 2, 2022 06:31
@taikitanaka3
Copy link
Contributor

taikitanaka3 commented Aug 2, 2022

@purewater0901
can you please write release note?

@purewater0901
Copy link
Contributor Author

sure

taikitanaka3 pushed a commit that referenced this pull request Aug 5, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
taikitanaka3 referenced this pull request in tier4/autoware.universe Aug 8, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…#1493)

* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(obstacle_velocity_planner): use-motion-utils

Signed-off-by: yutaka <purewater0901@gmail.com>

* change z interpolation to linear interpolation

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix arclength calculation

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants