fix(tensorrt_yolo): change the CMakeLists.txt folders for compiling error on Jetson AGX-Orin #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
added
the
component:perception
wep21
reviewed
Aug 4, 2022
| @@ -5,7 +5,8 @@ find_package(autoware_cmake REQUIRED) | |||
| autoware_package() | |||
|
|
|||
| option(CUDA_VERBOSE "Verbose output of CUDA modules" OFF) | |||
|
|
|||
| set(DEPRECATION_FLAG "-Wno-error=deprecated-declarations") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}") |
wep21
reviewed
Aug 4, 2022
Comment on lines
29
to
30
|
|
||
|
|
wep21
reviewed
Aug 4, 2022
| @@ -5,7 +5,8 @@ find_package(autoware_cmake REQUIRED) | |||
| autoware_package() | |||
|
|
|||
| option(CUDA_VERBOSE "Verbose output of CUDA modules" OFF) | |||
|
|
|||
| set(DEPRECATION_FLAG "-Wno-error=deprecated-declarations") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}") |
wep21
reviewed
Aug 4, 2022
| @@ -7,7 +7,8 @@ autoware_package() | |||
| option(CUDA_VERBOSE "Verbose output of CUDA modules" OFF) | |||
|
|
|||
| find_package(OpenCV REQUIRED) | |||
|
|
|||
| set(DEPRECATION_FLAG "-Wno-error=deprecated-declarations") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}") |
wep21
reviewed
Aug 4, 2022
| @@ -5,6 +5,9 @@ find_package(autoware_cmake REQUIRED) | |||
| autoware_package() | |||
|
|
|||
| option(CUDA_VERBOSE "Verbose output of CUDA modules" OFF) | |||
|
|
|||
| set(DEPRECATION_FLAG "-Wno-error=deprecated-declarations") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}") |
wep21
reviewed
Aug 4, 2022
| @@ -7,7 +7,8 @@ autoware_package() | |||
| option(CUDA_VERBOSE "Verbose output of CUDA modules" OFF) | |||
|
|
|||
| find_package(OpenCV REQUIRED) | |||
|
|
|||
| set(DEPRECATION_FLAG "-Wno-error=deprecated-declarations") | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |||
There was a problem hiding this comment.
Suggested change
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}" | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${DEPRECATION_FLAG}") |
Codecov Report
@@ Coverage Diff @@
## main #1436 +/- ##
========================================
- Coverage 9.59% 9.55% -0.04%
========================================
Files 1042 1047 +5
Lines 71837 72106 +269
Branches 15590 15590
========================================
Hits 6890 6890
- Misses 58978 59247 +269
Partials 5969 5969
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@wep21 can you approve it if it is ok now? |
saka1-s
pushed a commit
to saka1-s/autoware.universe
that referenced
this pull request
Aug 1, 2024
…d bring back to timer trigger autowarefoundation#8277 (autowarefoundation#1436) * fix: revert latency reduction logic and bring back to timer trigger Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * style(pre-commit): autofix * chore: remove unused variables Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jetson AGX-Orin uses Jetpack 5.1.0 which includes:
These library versions were giving deprecation errors while compiling some packages:
To fix this issue, compiler flag added to CMakeLists.txt. Should we add this situation to documantation? I opened an issue in autoware-documentation for this case.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.