Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_based_prediction): fix object yaw and velocity when necessary #1358

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Jul 15, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Currently, map based prediction has a serious issue that cannot handle the wrong yaw angle of the object. In order to fix this problem, I changed the condition and object yaw and velocity when necessary.

map_based_prediction-2022-07-15_16.15.20.mp4

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@taikitanaka3
Copy link
Contributor

[Q]
Just a question.
Does This PR have contradiction to this PR? #1348

@purewater0901
Copy link
Contributor Author

@taikitanaka3 No, this PR is independent of #1348

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #1358 (b92c6a3) into main (f0907b8) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1358      +/-   ##
========================================
- Coverage   9.64%   9.60%   -0.04%     
========================================
  Files       1096    1096              
  Lines      77124   77433     +309     
  Branches   17705   17705              
========================================
  Hits        7441    7441              
- Misses     62443   62752     +309     
  Partials    7240    7240              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 9.63% <0.00%> (ø) Carriedforward from b468b1f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...map_based_prediction/map_based_prediction_node.hpp 0.00% <ø> (ø)
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0907b8...b92c6a3. Read the comment docs.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@taikitanaka3 taikitanaka3 merged commit 57090fb into autowarefoundation:main Jul 15, 2022
@taikitanaka3 taikitanaka3 deleted the fix/map-based-prediction-yaw branch July 15, 2022 09:44
taikitanaka3 referenced this pull request in tier4/autoware.universe Jul 15, 2022
#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
autowarefoundation#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#1358)

* feat(map_based_prediction): fix object yaw and velocity when necessary

Signed-off-by: yutaka <purewater0901@gmail.com>

* fix condition

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

* delete unnecessary part

Signed-off-by: yutaka <purewater0901@gmail.com>
TetsuKawa added a commit to TetsuKawa/autoware.universe that referenced this pull request Jul 1, 2024
…ntrol-cmd-switcher

feat: add control cmd switcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants