Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(behavior_velocity_planner): use markdown extensions for image alignment #1299

Merged
merged 7 commits into from
Jul 14, 2022
Merged

docs(behavior_velocity_planner): use markdown extensions for image alignment #1299

merged 7 commits into from
Jul 14, 2022

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 11, 2022 •
edited
Loading

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

images are not shown in https://autowarefoundation.github.io/autoware.universe/main/planning/behavior_velocity_planner/crosswalk-design/

I fixed following points:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@satoshi-ota satoshi-ota changed the title docs(behavior_velocity_planner): fix image path in crosswalk design d… docs(behavior_velocity_planner): fix image path in crosswalk design document Jul 11, 2022
@satoshi-ota satoshi-ota added the type:documentation Creating or refining documentation. (auto-assigned) label Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022 •
edited
Loading

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-1299/
Modified URLs:

@satoshi-ota satoshi-ota force-pushed the docs/fix-image-path-crosswalk branch from fdca773 to 442596c Compare July 11, 2022 06:52
@codecov
Copy link

codecov bot commented Jul 11, 2022 •
edited
Loading

Codecov Report

Merging #1299 (8b97f94) into main (db01212) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #1299      +/-   ##
========================================
- Coverage   9.51%   9.47%   -0.04%     
========================================
  Files       1096    1096              
  Lines      76148   76468     +320     
  Branches   16991   17109     +118     
========================================
+ Hits        7244    7245       +1     
- Misses     62292   62585     +293     
- Partials    6612    6638      +26
Flag Coverage Δ *Carryforward flag
differential 4.95% <ø> (?)
total 9.47% <ø> (-0.02%) ⬇️ Carriedforward from 52366d0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
perception/tensorrt_yolo/src/nodelet.cpp 0.00% <0.00%> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
perception/tensorrt_yolo/lib/src/trt_yolo.cpp 0.00% <0.00%> (ø)
...erception/tensorrt_yolo/lib/include/calibrator.hpp 0.00% <0.00%> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...eption/tensorrt_yolo/lib/src/plugins/yolo_layer.cu 0.00% <0.00%> (ø)
...ption/tensorrt_yolo/lib/src/plugins/nms_plugin.cpp 0.00% <0.00%> (ø)
...tion/lidar_centerpoint/lib/network/network_trt.cpp 0.00% <0.00%> (ø)
...tion/traffic_light_classifier/utils/trt_common.cpp 0.00% <0.00%> (ø)
...on/lidar_apollo_instance_segmentation/src/node.cpp 0.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db01212...8b97f94. Read the comment docs.

@satoshi-ota
Copy link
Contributor Author

FYI:https://mkdocs.readthedocs.io/en/859/user-guide/configuration/#use_directory_urls

@satoshi-ota satoshi-ota changed the title docs(behavior_velocity_planner): fix image path in crosswalk design document docs(mkdocs): update config Jul 11, 2022
@satoshi-ota satoshi-ota marked this pull request as ready for review July 11, 2022 07:18
@satoshi-ota satoshi-ota force-pushed the docs/fix-image-path-crosswalk branch from 442596c to 5b3d059 Compare July 11, 2022 07:46
@satoshi-ota
docs(behavior_velocity_planner): fix image path in crosswalk design d…
a02f023 
…ocument

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the docs/fix-image-path-crosswalk branch from 5b3d059 to a02f023 Compare July 11, 2022 08:12
satoshi-ota and others added 3 commits July 11, 2022 17:34
@satoshi-ota
docs(mkdocs): add markdown extensions
36a8965 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@kenji-miyake
Merge branch 'main' into docs/fix-image-path-crosswalk
9d24113
@satoshi-ota
docs(behavior_velocity_planner): set width by px
b1d2b50 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the docs/fix-image-path-crosswalk branch from baa6086 to b1d2b50 Compare July 11, 2022 23:39
@satoshi-ota satoshi-ota changed the title docs(mkdocs): update config docs(behavior_velocity_planner): fix image path in crosswalk design document Jul 11, 2022
@satoshi-ota satoshi-ota changed the title docs(behavior_velocity_planner): fix image path in crosswalk design document docs(behavior_velocity_planner): use markdown extensions for image alignment Jul 11, 2022
@satoshi-ota
docs(behavior_velocity_planner): resize image
758d718 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
docs(behavior_velocity_planner): update image captions
52366d0 
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@yukkysaito
Copy link
Contributor

@satoshi-ota I cannot see the figure. is it correct?
image

@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Jul 12, 2022 •
edited
Loading

@satoshi-ota I cannot see the figure. is it correct? image

@yukkysaito yes, we can't see figures correctly in github.com such as plantuml, but these figs are shown in external documentation site.
https://autowarefoundation.github.io/autoware.universe/pr-1299/planning/behavior_velocity_planner/crosswalk-design/

In this PR, I use markdown_extensions for mkdocs.
FYI: https://squidfunk.github.io/mkdocs-material/reference/images/

miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@1222-takeshi @isamu-takagi
@mitsudome-r @tkimura4 @kenji-miyake @wep21 @yukkysaito @nnmm @TakaHoribe @esteve @sgermanserrano @taikitanaka3 @sgk-000 @kmiya @KeisukeShima @satoshi-ota @tkhmy @yamacir-kit @takayuki5168 @k0suke-murakami @YamatoAndo @pre-commit-ci
feat: add TierIV messages (#4)
c0dbdfe 
* Initial commit

* release v0.4.0

* Feature/stop reason (autowarefoundation#712)

* add stop reason msg

* add mock of stop resaon publisher

* change namespace of stop reason

* update stop reason msg

* add toRosPoint

* implement stop reason publisher of blind stop

* implement stop reason publisher of crosswalk

* implement stop reason publisher of intersection

* implement stop reason publisher of stop line

* implement stop reason publisher of trafficlight

* implement stop reason publisher of detection area

* fix bug

* remove unnecessary process

* add remained stop factor

* clean code

* fix bug

* not punlish stop reason if array size is 0

* add stop reason to stuck object in intersection

* add stop factor of obstacle stop planner

* add stop reason of surround_obstacle checker

* Apply review

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix message type

* delete unused message from cmake

* remove stopReasonStamped

* change topic name of stop reasons

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Support error in autoware state (autowarefoundation#728)

* Support Error in autoware_state_monitor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Refactor autoware_state_monitor

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Wait after planning completed

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Integrate FailedToArriveGoal and Error into Emergency state

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Publish tl states stamped (autowarefoundation#744)

* Add TrafficLightStateStamped.msg

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use msg instead of struct

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Publish traffic light state

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Check if lamp state is empty

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Apply clang-format

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Cosmetic change

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Revert "Publish tl states stamped (autowarefoundation#744)" (autowarefoundation#771)

This reverts commit 35a7e29e987afb29d9348b5f64866a584a65f753.

* Fix/publish tl state stamped (autowarefoundation#772)

* Publish tl states stamped (autowarefoundation#744)

* Add TrafficLightStateStamped.msg

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Use msg instead of struct

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Publish traffic light state

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Check if lamp state is empty

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Apply clang-format

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Cosmetic change

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Use dynamic pointer cast

Signed-off-by: Daisuke Nishimatsu <border_goldenmarket@yahoo.co.jp>

* Feature/add stop reason lane change (autowarefoundation#769)

* add stop reason of lane change planner

* add stop factor of blocked by obstacle

* delete typo

* add const

* delete unnecessary namespace

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add sample ros2 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Add ros2 perception msgs

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix dependency issue in autoware_control_msgs (autowarefoundation#22)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Port vehicle_cmd_gate to ROS2 (#3)

* Port vehicle_cmd_gate to ROS2

* Sim-time-respecting timer

* add autoware_debug_msg (autowarefoundation#54)

* add autoware_debug_msg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* rename to *stamped

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Fix format version (autowarefoundation#73)

* port motion_velocity_optimizer (autowarefoundation#77)

* port motion_velocity_optimizer

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix for warning

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix blockUntilVehiclePositionAvailable()

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Port of obstacle avoidance planner to ROS2 (autowarefoundation#83)

* Port to ROS2

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Removed ros/console include

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Added THROTTLE

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Changed numbers to floats

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Removed <double> from params

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Added new msg

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Use new msg

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Replaced dynamic reconfigure

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Added EnableAvoidance.msg

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Fixed parameter mismatch

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Port behavior_velocity_planner to ROS2 (autowarefoundation#80)

* Revert "Add geometry2 to repos (autowarefoundation#76)"

This reverts commit 6d22704.

* Automatic parts of the package port

* Interesting part

* Fix typo in package.xml

* Review comments

* Child logger names

* Document logging duration

Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>

* Ros2 v0.8.0 awapi and system msgs (autowarefoundation#274)

* Ros2 v0.8.0 engage (autowarefoundation#342)

* [autoware_vehicle_msgs]: Add engage message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [as]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [awapi_awiv_adapter]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [web_controller]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [vehicle_cmd_gate]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_state_monitor]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_control_msgs]: Remove EngageMode message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [simple_planning_simulator]: Update message

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Ros2 v0.8.0 lane_change_planner (autowarefoundation#322)

* Remove lane_change_planner v0.5

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Import lane_change_planner v0.8 (ROS1)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Modify header files

* Remove header disable

* Modify msg namespace

* Modify time type

* Modify pub/sub class

* Modify node handle, etc.

* Modify ConstPtr

* Modify entry point

* Modify time and publisher

* Modify parameter, timer, and subscription

* Modify data manager

* Modify route handler

* Modify state machine

* Modify utility

* Fix arguments

* Modify states part1

* Modify states part2

* Modify common function

* Fix for lint

* Fix for lint

* Modify comment type

* Add copyright

* Use duration from_seconds

* Use double quotes for non-system headers

* Fix include order

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Replace std_msgs Bool

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix line length

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix latch topic subscription

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix stamp initialization and reference

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add super class destructor and fix waitForData

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Ros2 v0.8.0 remove std msgs awapi (autowarefoundation#348)

* [autoware_vehicle_msgs] add BatteryStatus msg

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_planning_msgs] add ExpandStopRange and StopSpeedExceeded messages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* [autoware_api_msgs] add DoorControlCommand, StopCommand, and VelocityLimit messages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove std_msgs related to autoware_awaiv_adapter node

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* apply ament_uncrustify

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix build failure

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* fix test failures

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* address review commends

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#393)

* add nullptr check when publish concatenate data (autowarefoundation#369)

* Add warning msg when concat pointcloud is not published (autowarefoundation#388)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add timeout notification stamp msgs (autowarefoundation#363)

* add timeout notification stamp msgs

* fix uncursify

* delete timeout notification stamped

* Revert "delete timeout notification stamped"

This reverts commit 365d29209f6a7f5ec75eb80c5d8c2ef38daeae79.

* fix message

Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* modify pose_initialize for foa  (autowarefoundation#382)

* pose_initialize for foa (autowarefoundation#1171)

* pose_initialize for foa

Signed-off-by: Yamato ANDO <yamato.ando@gmail.com>

* rename topic

Signed-off-by: Yamato ANDO <yamato.ando@gmail.com>

* fix topic name

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Add autoware version node (autowarefoundation#394)

* Add autoware version node

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove todo

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Remove unused variable

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix node name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* fix typo (autowarefoundation#427)

* Fix typo in common module (autowarefoundation#433)

* Unify Apache-2.0 license name (autowarefoundation#1242)

* Porting remote cmd selector (autowarefoundation#1286)

* Feature/add remote cmd selector (autowarefoundation#1179)

* Add in/out args of remote_cmd_converter.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change remote input topic of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add msgs for remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove VehicleCommand support in autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix porting miss

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix missing function

* modify xml format

* fix include guard

* add callback group

* modify remap name

* Revert "modify remap name"

This reverts commit 169cc8d28442825b1d61b0439b9892c913304527.

* change topic name

* use rclcpp_component

* Remove autoware_debug_msgs from autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default mode of autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add perception traffic light state output (autowarefoundation#1302)

* Add perception traffic light state output

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Modify message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Apply message type to relay

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix msgs (autowarefoundation#1379)

* Fix msgs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [autoware_planning_rviz_plugin]: Fix lint

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Message refinement (autowarefoundation#1381)

* Message refinement

* Simplify CMakeLists.txt with ament cmake auto

* Add test

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* [autoware_planning_msgs]: Fix dependency

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix package.xml

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix package.xml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix ament_cmake_auto

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2/create/external commands (autowarefoundation#1299)

* add remote message

* add remote commands

* fix topic

* remove unnecessary topic

* remove unused topic

* add external cmd instead

* ToExternalComd

* fix topic in joy con

* publish perception and external tl_state for mlops (autowarefoundation#1350) (autowarefoundation#1375)

* publish perception and external tl_state for mlops

* fix tl_state time stamp

Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>

* Add newlines

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add PR template (#3)

* Add PR template

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update PULL_REQUEST_TEMPLATE.md

* Add CI (#4)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* change msg type looking traffic light state (autowarefoundation#1455) (#6)

* change msg type looking traffic light state

* fix msg name

* using namespace

* change function name

* fix typo

* add readme

* Update awapi/awapi_awiv_adapter/Readme.md

fix typo

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* Fix dependency type of rosidl_default_generators (autowarefoundation#15)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add auto-main-sync CI workflow for develop (autowarefoundation#16)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add autoware_api_msgs (autowarefoundation#12)

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Feature/add virtual traffic light planner (autowarefoundation#9)

* Add VIRTUAL_TRAFFIC_LIGHT to StopReason.msg

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add VirtualTrafficLightState msgs to autoware_system_msgs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add InfrastructureCommand msgs to autoware_planning_msgs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix msgs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Move messages to autoware_v2x_msgs

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix dependency type of rosidl_default_generators

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix dependency type of rosidl_default_generators (autowarefoundation#19)

* Change CI docker images to setup-ros-docker (autowarefoundation#20)

* Change CI docker images to setup-ros-docker

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace foxy with galactic

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add DEBIAN_FRONTEND=noninteractive to rosdep install (autowarefoundation#21)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Update colcon-package-selection in build_and_test_pr.yml (autowarefoundation#22)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add autoware_simulation_msgs (autowarefoundation#13)

* add autoware_simulation_msgs

* update event name

* Add autoware api (autowarefoundation#29)

* add autoware multimedia msgs

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* add newline

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* change name to autoware_hmi_msgs

Signed-off-by: tkhmy <tkh.my.p@gmail.com>

* Rename external select message (autowarefoundation#8)

* Rename external select message

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add selector mode to unknown

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix selector mode constant

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix format

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Move control command messages to external api

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add build dependency

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix CI

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Co-authored-by: tkhmy <tkh.my.p@gmail.com>

* Fix CI for develop branch (autowarefoundation#31)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add emergency_holding flag to HazardStatus (autowarefoundation#25)

* add EmergencyState.msg (autowarefoundation#32)

* Add new workflow `sync-public.yaml` to sync with `AutowareArchitectureProposal_msgs` (autowarefoundation#35)

* Add new workflow `sync-public.yaml` to sync with `AutowareArchitectureProposal_msgs`

* Remove this workflow specific comments

* Remove some this workflow specific comments

* Rename `oss` to `public`

* Replace branch name `main` to more generic description

* Add line `fetch-depth: 0` (autowarefoundation#36)

* Add EmergencyStateStamped.msg (autowarefoundation#38)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add sync-public-develop.yaml (autowarefoundation#42)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change proposal sync app ID (autowarefoundation#44)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add MultiArrayDimension/Layout, and update MultiArrayMsgs (autowarefoundation#28)

* add MultiArrayDimension/Layout, and update MultiArrayMsgs

* add kind of license

* Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#48)

* add vehicle msg

* add pacmod interface

* add eps controller

* use each control commands instead of vehicle command

* fixed details

* fixed speell check

* const

* fixed brake status

* publish cmd when recieving ctrl cmd

* fix shift cmd ptr

* remove unused function and set proper license

* fix names

* fix typo for pacmod

* remove unnecessary waiting

* use flags, limit, multiarray

* remove accel brake dependency

* fix retrun value

* replace eps to steer

* cosmetic change for namespace

* fix segfo and retval

* Use Enum instead of int

* remove unused var

* add const

* rename to calcFFMap

* prev time steer calc

* add sample csv

* add new line

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* remove EmergencyMode and DricingCapability (autowarefoundation#33)

* develop -> main sync (autowarefoundation#53)

* Add detected object with feature (autowarefoundation#54)

* Add detected object with feature

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add autoware_auto_msgs

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Revert "Add detected object with feature (autowarefoundation#54)" (autowarefoundation#57)

This reverts commit 3fcfe9936361928256ed5ffa7d8a1ef4c978ca09.

* Add detected object with feature (autowarefoundation#54) (autowarefoundation#59) (#4)

* Add detected object with feature (autowarefoundation#54) (autowarefoundation#59)

* Add detected object with feature

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* add autoware_auto_msgs

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* update build depends

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Add message converter (autowarefoundation#58)

* Add message converter

* Move autoware state converter

* add VehicleEmergency (autowarefoundation#55)

* Add two convert method (autowarefoundation#64)

* add convert method from iv_shift to auto_gear

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* remove space

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* add convert method from for turn & hazard signal

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* fix dependency of iv_auto_msgs converter (autowarefoundation#8)

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* move actuation msg (autowarefoundation#66)

* Revert "move actuation msg (autowarefoundation#66)"

This reverts commit d8e3ccdcabacab819360cf399442950cc162a648.

* merge autoware_localization_srvs to autoware_localization_msgs

* rename pose_with_cov to pose_with_covariance

* add steering wheel status stamped

* fix: remove workflow and PR_TEMPLATE

* fix: remove autoware_api_msgs dependency

* ci(pre-commit): autofix

Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: Esteve Fernandez <esteve@apache.org>
Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com>
Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Shigeki Kobayashi <32808802+sgk-000@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: satoshi-ota <satoshi.ota@gmail.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: tkhmy <tkh.my.p@gmail.com>
Co-authored-by: Tatsuya Yamasaki <httperror@404-notfound.jp>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: tanaka3 <ttatcoder@outlook.jp>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@taikitanaka3 @KeisukeShima
@kenji-miyake @h-ohta @isamu-takagi @k0suke-murakami @tkimura4 @rej55
feat: add external cmd selector package (autowarefoundation#78)
bbbea7b 
* Porting remote cmd selector (autowarefoundation#1286)

* Feature/add remote cmd selector (autowarefoundation#1179)

* Add in/out args of remote_cmd_converter.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change remote input topic of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add msgs for remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove VehicleCommand support in autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix porting miss

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix missing function

* modify xml format

* fix include guard

* add callback group

* modify remap name

* Revert "modify remap name"

This reverts commit 169cc8d28442825b1d61b0439b9892c913304527.

* change topic name

* use rclcpp_component

* Remove autoware_debug_msgs from autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default mode of autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix ament (autowarefoundation#1307)

* Ros2/create/external commands (autowarefoundation#1299)

* add remote message

* add remote commands

* fix topic

* remove unnecessary topic

* remove unused topic

* add external cmd instead

* ToExternalComd

* fix topic in joy con

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* suppress warnings for control packages (autowarefoundation#1892)

* add Werror

* add maybe unused

* Add autoware api (autowarefoundation#1979)

* Move launch file of external_cmd_selector (autowarefoundation#2017)

* Move launch file of external_cmd_selector

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Add copyright

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Use DeclareLaunchArgument

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix external command api name

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Move common parameters

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix format

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Fix format

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030)

* Use EmergencyState instead of deprecated EmergencyMode

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use stamped type

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Improve diagnostic tree for future extensions (autowarefoundation#2153)

* change resource monitoring group

* implement diagnostic tree proposal

* rename v2x param file

* add v2x to launch

* add dummy analyzer to avoid format error

* modify external control

* rename vehicle_ecu_errors

* fixup

* remove num_items

* fix error

* add heartbeat to external command selector

* Restore sensing/node_alive_monitoring

* Update system/autoware_error_monitor/config/diagnostic_aggregator/sensing.param.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* add sensor_kit arg for diagnostic_agg

* change sensor_kit's default value

* add _ prefix to hide parameter file

* delete dummy parameter

* change to use update_functions

* add extra_agg_config_file_vehicle

* change initializer

* remove line

* Update system/autoware_error_monitor/config/diagnostic_aggregator/system.param.yaml

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* change hearbeat diag

* add clock group

* update sensing diag

* Remove discard and v2x

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix heartbeat name

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add remote_external_control

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add external_control

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename remote_control to external_control

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename command_gate to control_command_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Simplify resource monitoring

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove sensing from autoware_error_monitor.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove trajectory_deviation

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove vehicle specific settings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add blank lines

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore matching_score error

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove debug_data_logger

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add trajectory_validation

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Specify children for performance_monitoring

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Comment out route_validation

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert "Remove trajectory_deviation"

This reverts commit 199132f1a6c7083440f0ef9a956b0663d45f4531.

* Remove control_command_topic_status

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Disable some diagnostics for planning simulator

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add TODO comment

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Enable /autoware/vehicle/node_alive_monitoring in planning simulator

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix missing dependency of external_cmd_selector (autowarefoundation#2324)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port part of external_cmd_selector (autowarefoundation#497)

* port part of external_cmd_selector

Signed-off-by: Kosuke Murakami <kosuke.murakami@tier4.jp>

* add convert function

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* port signal

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

* Update control/external_cmd_selector/include/external_cmd_selector/external_cmd_selector_node.hpp

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>

* Fix publisher in external_cmd_selector (autowarefoundation#676)

Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
miursh pushed a commit to miursh/autoware.universe that referenced this pull request Jul 12, 2022
@taikitanaka3 @mitsudome-r
@rej55 @kenji-miyake @nnmm @sgermanserrano @TakaHoribe @j4tfwm6z @tkimura4 @wep21 @KeisukeShima @h-ohta @isamu-takagi @takayuki5168 @pre-commit-ci @1222-takeshi
feat: add autoware joy controller (autowarefoundation#72)
d44beb2 
* release v0.4.0

* Support G29 controller in autoware_joy_controller (autowarefoundation#699)

* Add map for G29 controller

* Add new line at end of file

* Change structure of JoyConverterBase class

* Rename PS4 -> DS4

* Rename controler_type -> joy_type

* Set joy_type by console input

* Change doc

* Remap g29 controller

* Remap AccelPedal -> accel, BrakePedal -> brake

* Remove [autoware_joy_controller] from ROS_INFO

Co-authored-by: Fumiya Watanabe <fumiya.watanabe@tier4.jp>

* Change key map for G29 controller and set deadzone parameter (autowarefoundation#740)

* Add missing dependencies of autoware_joy_controller (autowarefoundation#755)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add sample ros2 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* remove ROS1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Revert "remove ROS1 packages temporarily"

This reverts commit c98294b0b159fb98cd3091d34a626d06f29fdece.

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

* Rename launch files to launch.xml (autowarefoundation#28)

* Rename h files to hpp (autowarefoundation#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143)

* Use quotes for includes where appropriate (autowarefoundation#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Port autoware joy controller (autowarefoundation#124)

* Port

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Fixed package.xml

* now() to use node clock

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Fix include

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Clear compilation warnings

Signed-off-by: Servando German Serrano <servando.german.serrano@linaro.org>

* Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* [update to v0.8.0] autoware joy controller (autowarefoundation#251)

* restore filename to original for version update

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* Enable to change sensitivity (autowarefoundation#868)

* Improve remote emergency stop (autowarefoundation#900)

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency to system_emergency in vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add emergency stop feature to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix frame_id of vehicle_cmd_gate output

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename /remote/emergency to /remote/emergency_stop in autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename /remote/emergency to /remote/emergency_stop in remote_cmd_converter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename /remote/emergency to /remote/emergency_stop in autoware_api

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Check emergency_stop timeout in remote_cmd_converter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore timeout = 0.0

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add config_file to arg

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove unnecessary lines

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Wait for first heartbeat

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add clear_emergency_stop service

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Call clear_external_emegency_stop service from autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename function

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert: Wait for first heartbeat

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix console messages

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Move emergency_stop diag to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add heartbeat to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Revert: Move emergency_stop diag to vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* patch in real-vehicle

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp>

* restore file name

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* [tmp] fix build error

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix service

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix format

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix service usage

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix launch var

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#352)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove prefix 'default_' of yaml files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename diagnostic_aggregator's param files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix overlooked parameters

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove using in global namespace (autowarefoundation#379)

* remove using in global namespace (autowarefoundation#1166)

* remove using in global namespace

* Revert "remove using in global namespace"

This reverts commit 7f120509c9e3a036a38e84883868f6036bca23ad.

* Add package namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [autoware_joy_controller] add lint tests

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix namespace (autowarefoundation#414)

* add use_sim-time option (autowarefoundation#454)

* Fix for rolling (autowarefoundation#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Make control modules components (autowarefoundation#1262)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove use_sim_time for set_parameter (autowarefoundation#1260)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Remove autoware_debug_msgs from autoware_joy_controller (autowarefoundation#1303)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Porting remote cmd selector (autowarefoundation#1286)

* Feature/add remote cmd selector (autowarefoundation#1179)

* Add in/out args of remote_cmd_converter.launch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change remote input topic of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add msgs for remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add remote_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Rename remote_cmd_selector to external_cmd_selector

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove VehicleCommand support in autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Support external_cmd_source in autoware_joy_controller.launch (autowarefoundation#1194)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix porting miss

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix missing function

* modify xml format

* fix include guard

* add callback group

* modify remap name

* Revert "modify remap name"

This reverts commit 169cc8d28442825b1d61b0439b9892c913304527.

* change topic name

* use rclcpp_component

* Remove autoware_debug_msgs from autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Change default mode of autoware_joy_controller

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ros2/create/external commands (autowarefoundation#1299)

* add remote message

* add remote commands

* fix topic

* remove unnecessary topic

* remove unused topic

* add external cmd instead

* ToExternalComd

* fix topic in joy con

* Fix -Wunused-parameter (autowarefoundation#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix mistake

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>

* Add autoware api (autowarefoundation#1979)

* Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030)

* Use EmergencyState instead of deprecated EmergencyMode

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Use stamped type

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* add sort-package-xml hook in pre-commit (autowarefoundation#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Add selected external command API (autowarefoundation#2053)

* submit engage with api service from joy controller (autowarefoundation#2320)

* fix engagew with api

* delete unused

* fix for uncrustify

* revive vehicle_engage

* some fix

* revive autoware name

* fix service name

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* port autoware joy controller (autowarefoundation#588)

* port autoware joy controller

* fix compile error

* use odometry instead of twist

* update launch

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>

* update README.md in autoware_joy_controller (autowarefoundation#593)

* update README.md

* update README.md

* fix typo

* Update control/autoware_joy_controller/README.md

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* update README.md

Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>

* fix format

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Fumiya Watanabe <fumiya.watanabe@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Nikolai Morin <nnmmgit@gmail.com>
Co-authored-by: Servando <43142004+sgermanserrano@users.noreply.github.com>
Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Co-authored-by: jpntaxi4943-autoware <proj-jpntaxi@tier4.jp>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki.murooka@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
@satoshi-ota
Copy link
Contributor Author

Pass required CI checks 😄
Could you give me any comment or Approve ?

@satoshi-ota
Copy link
Contributor Author

Pass required CI checks smile Could you give me any comment or Approve ?

@yukkysaito @kenji-miyake @TakaHoribe

TakaHoribe
TakaHoribe approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 21889d7 into autowarefoundation:main Jul 14, 2022
@satoshi-ota satoshi-ota deleted the docs/fix-image-path-crosswalk branch July 14, 2022 03:56
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Jul 15, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@satoshi-ota @kenji-miyake @boyali
docs(behavior_velocity_planner): use markdown extensions for image al…
069ef29 
…ignment (tier4#1299)

* docs(behavior_velocity_planner): fix image path in crosswalk design document

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(mkdocs): add markdown extensions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): set width by px

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): resize image

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): update image captions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @kenji-miyake @boyali
docs(behavior_velocity_planner): use markdown extensions for image al…
cff7923 
…ignment (tier4#1299)

* docs(behavior_velocity_planner): fix image path in crosswalk design document

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(mkdocs): add markdown extensions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): set width by px

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): resize image

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): update image captions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@satoshi-ota @kenji-miyake @boyali
docs(behavior_velocity_planner): use markdown extensions for image al…
3966ba1 
…ignment (tier4#1299)

* docs(behavior_velocity_planner): fix image path in crosswalk design document

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(mkdocs): add markdown extensions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): set width by px

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): resize image

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): update image captions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
@satoshi-ota @kenji-miyake
docs(behavior_velocity_planner): use markdown extensions for image al…
110c350 
…ignment (autowarefoundation#1299)

* docs(behavior_velocity_planner): fix image path in crosswalk design document

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(mkdocs): add markdown extensions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): set width by px

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): resize image

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): update image captions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@satoshi-ota @kenji-miyake @boyali
docs(behavior_velocity_planner): use markdown extensions for image al…
06b2407 
…ignment (tier4#1299)

* docs(behavior_velocity_planner): fix image path in crosswalk design document

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(mkdocs): add markdown extensions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): set width by px

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): resize image

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* docs(behavior_velocity_planner): update image captions

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
@kenji-miyake kenji-miyake mentioned this pull request May 4, 2023
Merged
4 tasks
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jun 12, 2024
@danielsanchezaran
fix(start_planner): issue when ego does not straddle lane bounds and … (
72bd87f 
autowarefoundation#1299)

fix(start_planner): issue when ego does not straddle lane bounds and starts from 0 speed (autowarefoundation#7004)

* fix issue when ego does not straddle lane bounds and starts from 0 speed



* add new status for ego departed



---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake left review comments

@TakaHoribe TakaHoribe TakaHoribe approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

Assignees
No one assigned
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@satoshi-ota @yukkysaito @TakaHoribe @kenji-miyake