-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vehicle_cmd_gate): initialization handling for emergency state #1077
fix(vehicle_cmd_gate): initialization handling for emergency state #1077
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1077 +/- ##
========================================
- Coverage 9.00% 8.98% -0.02%
========================================
Files 1022 1022
Lines 69292 69425 +133
Branches 11692 11777 +85
========================================
+ Hits 6238 6239 +1
- Misses 57869 57998 +129
- Partials 5185 5188 +3
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your commit!
LGTM!
fix(vehicle_cmd_gate): initialization handling for emergency state (#1077)
…1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…utowarefoundation#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
…utowarefoundation#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ier4#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ier4#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ier4#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ier4#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…ier4#1077) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Fixed a problem that an emergency stop command is thrown when onTimer() runs before receiving emergency_state.
Publish emergency stop command ⇨ receives emergency_state and stops output of control commands ⇨ topic hz monitoring node makes an error.
Related links
Tests performed
tested on psim.
/control/command/control_cmd
is not publishedNotes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.