Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vehicle_cmd_gate): initialization handling for emergency state #1077

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 10, 2022

Description

Fixed a problem that an emergency stop command is thrown when onTimer() runs before receiving emergency_state.

Publish emergency stop command ⇨ receives emergency_state and stops output of control commands ⇨ topic hz monitoring node makes an error.

Related links

Tests performed

tested on psim.

  1. run psim
  2. set initialpose (no goal)
  3. check if the /control/command/control_cmd is not published

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from yn-mrse June 10, 2022 13:56
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1077 (ec5403a) into main (1dfab8c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1077      +/-   ##
========================================
- Coverage   9.00%   8.98%   -0.02%     
========================================
  Files       1022    1022              
  Lines      69292   69425     +133     
  Branches   11692   11777      +85     
========================================
+ Hits        6238    6239       +1     
- Misses     57869   57998     +129     
- Partials    5185    5188       +3     
Flag Coverage Δ *Carryforward flag
differential 18.09% <0.00%> (?)
total 8.98% <0.00%> (ø) Carriedforward from 1dfab8c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...gate/include/vehicle_cmd_gate/vehicle_cmd_gate.hpp 0.00% <ø> (ø)
control/vehicle_cmd_gate/src/vehicle_cmd_gate.cpp 0.39% <0.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfab8c...ec5403a. Read the comment docs.

Copy link
Contributor

@yn-mrse yn-mrse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your commit!
LGTM!

@yn-mrse yn-mrse merged commit 04f2b53 into autowarefoundation:main Jun 10, 2022
@yn-mrse yn-mrse deleted the fix/vehicle-cmd-gate-emergency-state-initialization branch June 10, 2022 16:04
tier4-autoware-public-bot bot referenced this pull request in tier4/autoware.universe Jun 10, 2022
fix(vehicle_cmd_gate): initialization handling for emergency state (#1077)
yn-mrse referenced this pull request in tier4/autoware.universe Jun 10, 2022
…1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…utowarefoundation#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
TakaHoribe referenced this pull request in tier4/autoware.universe Jun 21, 2022
…1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
…ier4#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…ier4#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…ier4#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…ier4#1077)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants