Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity): use pose for min velocity if the object is stopped #1052

Merged

Conversation

TomohitoAndo
Copy link
Contributor

@TomohitoAndo TomohitoAndo commented Jun 7, 2022

Signed-off-by: Tomohito Ando tomohito.ando@tier4.jp

Description

  • fixed the calculation for bounding box of the obstacle when the obstacle is not moving.

before this PR

Orientation of the obstacle was wrong and the obstacle beside the pass was considered to be collision.

before

after this PR

Orientation of the obstacle has been fixed.
after

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…opped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1052 (26a63fd) into main (bcac01e) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1052      +/-   ##
========================================
- Coverage   9.21%   9.01%   -0.21%     
========================================
  Files       1010    1010              
  Lines      65516   69015    +3499     
  Branches   11380   11861     +481     
========================================
+ Hits        6039    6223     +184     
- Misses     54482   57585    +3103     
- Partials    4995    5207     +212     
Flag Coverage Δ *Carryforward flag
differential 5.08% <0.00%> (?)
total 9.04% <0.00%> (-0.18%) ⬇️ Carriedforward from d45e71d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
...d_api_msgs/srv/interface_version__type_support.cpp 54.54% <0.00%> (-45.46%) ⬇️
...l/dds_fastrtps/interface_version__type_support.cpp 32.71% <0.00%> (-20.33%) ⬇️
...s/srv/detail/interface_version__type_support_c.cpp 31.00% <0.00%> (-15.97%) ⬇️
.../include/pose_initializer/copy_vector_to_array.hpp 60.00% <0.00%> (-15.00%) ⬇️
...tier4_autoware_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
control/trajectory_follower/src/mpc_trajectory.cpp 76.47% <0.00%> (-4.78%) ⬇️
...api_msgs/srv/detail/interface_version__functions.c 7.56% <0.00%> (-4.09%) ⬇️
map/lanelet2_extension/test/src/test_projector.cpp 56.66% <0.00%> (-4.05%) ⬇️
...ning_evaluator/include/planning_evaluator/stat.hpp 33.33% <0.00%> (-2.39%) ⬇️
... and 500 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcac01e...26a63fd. Read the comment docs.

@TomohitoAndo TomohitoAndo changed the title fix(behavior_velocity): use pose for min velocity if the object is st… fix(behavior_velocity): use pose for min velocity if the object is stopped Jun 7, 2022
Copy link
Contributor

@0x126 0x126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota
Copy link
Contributor

calculate...?

Screenshot from 2022-06-09 14-22-44

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo
Copy link
Contributor Author

TomohitoAndo commented Jun 9, 2022

@satoshi-ota

calculate...?

oh, thanks! I fixed. 26a63fd

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomohitoAndo TomohitoAndo enabled auto-merge (squash) June 9, 2022 05:38
@TomohitoAndo TomohitoAndo merged commit 800e815 into autowarefoundation:main Jun 9, 2022
@TomohitoAndo TomohitoAndo deleted the fix-creating-bounding-box branch June 9, 2022 06:12
TomohitoAndo added a commit to TomohitoAndo/autoware.universe that referenced this pull request Jun 9, 2022
…opped (autowarefoundation#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
TomohitoAndo referenced this pull request in tier4/autoware.universe Jun 9, 2022
…opped (#1052) (#62)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…opped (autowarefoundation#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
Signed-off-by: SoohyeokPark-MORAI <shpark.morai@gmail.com>
SoohyeokPark-MORAI pushed a commit to SoohyeokPark-MORAI/autoware.universe that referenced this pull request Jun 15, 2022
…opped (autowarefoundation#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Jul 1, 2022
…opped (tier4#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…opped (tier4#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…opped (tier4#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…opped (tier4#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…opped (tier4#1052)

* fix(behavior_velocity): use pose for min velocity if the object is stopped

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>

* fix typo

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
sykwer pushed a commit to sykwer/autoware.universe that referenced this pull request Jan 3, 2024
…ndation#5718) (autowarefoundation#1052)

* fix(path_smoother): faster elastic band by sparse matrix



* fix typo



---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 14, 2024
…ndation#5718) (autowarefoundation#1052)

* fix(path_smoother): faster elastic band by sparse matrix



* fix typo



---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants