Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dummy_perception_publisher publishes objects with acceleration #622

Closed
3 tasks done
takayuki5168 opened this issue Apr 1, 2022 · 8 comments
Closed
3 tasks done
Assignees
Labels
component:tools Utility and debugging software. (auto-assigned) type:new-feature New functionalities or additions, feature requests.

Comments

@takayuki5168
Copy link
Contributor

takayuki5168 commented Apr 1, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently dummy_perception_publisher can publish the obstacle with the constant velocity. To realize more flexible use case, I'm thinking to add acceleration/deceleration functions to dummy_perception_publisher. This function will be helpful for obstacle stop/slow down (including adaptive_cruise_controller).

Purpose

To realize more flexible use case, I'm thinking to add acceleration/deceleration functions to dummy_perception_publisher. This function will be helpful for obstacle stop/slow down (including adaptive_cruise_controller).

Possible approaches

The current message to represent initial pose/twist of objects is InitialState.
https://github.com/autowarefoundation/autoware.universe/blob/main/simulator/dummy_perception_publisher/msg/InitialState.msg

Instead of InitialState, how about Motion or State message as follows.

geometry_msgs/PoseWithCovariance initial_pose_covariance
geometry_msgs/TwistWithCovariance initial_twist_covariance
double acceleration

Definition of done

Objects' acceleration can be changed with dummy_perception_publisher.

@takayuki5168
Copy link
Contributor Author

@yukkysaito

@yukkysaito
Copy link
Contributor

@takayuki5168
I agree with adding accel.

how about Motion or State message as follows.

This was a little confusing.
Are you saying that there is a type called Motion, State? If so, please provide a link.

@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Apr 4, 2022

@yukkysaito

Are you saying that there is a type called Motion, State? If so, please provide a link.

Sorry to be confused. There is no existing messages. I just named Motion or State, whose content is as follows.

geometry_msgs/PoseWithCovariance initial_pose_covariance
geometry_msgs/TwistWithCovariance initial_twist_covariance
double acceleration

or it might be better like this

geometry_msgs/PoseWithCovariance initial_pose_covariance
geometry_msgs/TwistWithCovariance initial_twist_covariance
geometry_msgs/Accel accel

@takayuki5168
Copy link
Contributor Author

I was thinking that in dummy perception publisher, in order to represent the case where the obstacle is running and will stop (= initial twist linear x is positive and acceleration is negative), the updated velocity (acceleration is added every cycle) will be made non-negative.
But sometimes we may want to make obstacle running backward, which has a conflict with a rule that the update velocity is non-negative.

If we have max_velocity and min_velocity variable in a new message, which I named Motion or State, the conflict can be resolved, but I feel the number of variables is too many.
Do you have any good idea.

@takayuki5168
Copy link
Contributor Author

max_velocity and min_velocity can be in config file of dummy_perception_publisher. Those values cannot be changed every obstacles though.

@yukkysaito
Copy link
Contributor

I would prefer the following

geometry_msgs/PoseWithCovariance initial_pose_covariance
geometry_msgs/TwistWithCovariance initial_twist_covariance
geometry_msgs/AccelWithCovariance initial_accel_covariance
  • The dummy perception may consider in the future.
  • Pose and twist are also cov for the above reason.

max_velocity and min_velocity can be in config file of dummy_perception_publisher. Those values cannot be changed every obstacles though.

I agree with you.

@BonoloAWF BonoloAWF added the type:new-feature New functionalities or additions, feature requests. label Apr 19, 2022
@mitsudome-r mitsudome-r added the component:tools Utility and debugging software. (auto-assigned) label Apr 19, 2022
@stale
Copy link

stale bot commented Jun 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 18, 2022
@takayuki5168
Copy link
Contributor Author

Fixed by #1853

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Sep 22, 2022
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this issue Jul 3, 2023
kyoichi-sugahara pushed a commit that referenced this issue Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tools Utility and debugging software. (auto-assigned) type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants