Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add bus-odd arch discussion summary #48

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 8, 2022

add bus odd arch discussion summary for planning/control/vehicle as of today.

This will be updated through discussion.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe changed the title docs: add bus odd arch discussion summary for planning/control/vehicle docs: add bus-odd arch discussion summary Mar 8, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe added the type:documentation Creating or refining documentation. label Mar 8, 2022
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@mitsudome-r mitsudome-r requested a review from xmfcx March 8, 2022 14:26
mitsudome-r
mitsudome-r previously approved these changes Mar 9, 2022
- [geometry_msgs::msg::Polygon](https://docs.ros.org/en/noetic/api/geometry_msgs/html/msg/Polygon.html) polygon
- float height

#### (NEW) Traffic Light Response
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to mention (NEW) in the design document.
Same with the other sections.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Addressed in 90ce7ea

@mitsudome-r mitsudome-r self-requested a review March 9, 2022 06:52
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
mitsudome-r
mitsudome-r previously approved these changes Mar 15, 2022
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will create another PR to add interface for other components (e.g. localization, sensing, perception)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@mitsudome-r
Copy link
Member

The CI failure is from the document that was not modified in the PR. I will merge this and the CI should be fixed with another PR.

@mitsudome-r mitsudome-r merged commit 17ccfc4 into autowarefoundation:main Mar 15, 2022
@mitsudome-r mitsudome-r deleted the docs/add-bus-odd-arch-discussion-summary branch March 15, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants