Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Internalize JSON.NET dependency #30

Closed
davidfowl opened this issue Mar 4, 2014 · 9 comments
Closed

Internalize JSON.NET dependency #30

davidfowl opened this issue Mar 4, 2014 · 9 comments
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

Today we're using JSON.NET as a package and that's no good for apps and frameworks that use this framework. This is part of the work #29

@davidfowl davidfowl added this to the Post Alpha milestone Apr 17, 2014
@davidfowl davidfowl modified the milestones: 1.0.0-alpha3, Backlog Jun 24, 2014
@ChengTian
Copy link
Contributor

Just talked to @Eilon and we might want to use DataContractJsonSerializer instead of a new parser written by us. Need further discussion and mark this as blocked.

@davidfowl
Copy link
Member Author

Ummmmmmmmmmmmmm.

@Eilon
Copy link
Member

Eilon commented Jun 26, 2014

No ummmmmmmmmming just yet! Specifically, we should consider using DataContractJsonSerializer, if it supports what we need. I don't think it's in CoreCLR yet, but it will be (according to what I've heard). But if it doesn't support what we want (e.g. comments), then we're off to the races.

@davidfowl
Copy link
Member Author

That serializer is terrible 😄

@JamesNK
Copy link
Member

JamesNK commented Jun 27, 2014

Just copy and paste JsonReader + JsonTextReader out of Json.NET, then write some code to load the JSON into a simple Dictionary/List/value object model.

Example of loading JSON into a simple object model using JsonReader: https://github.com/JamesNK/Newtonsoft.Json/blob/bcd6982419c6165ed2c606eb9994c1aa6bce3735/Src/Newtonsoft.Json/Converters/ExpandoObjectConverter.cs#L62-L138

@davidfowl davidfowl assigned davidfowl and unassigned ChengTian Jul 21, 2014
@davidfowl davidfowl modified the milestones: 1.0.0-alpha4, 1.0.0-beta1 Sep 8, 2014
@davidfowl davidfowl modified the milestones: Backlog, 1.0.0-beta1 Oct 7, 2014
@muratg muratg modified the milestones: 1.0.0-rc1, Backlog Feb 14, 2015
@muratg muratg assigned davidfowl and unassigned davidfowl Feb 14, 2015
@davidfowl davidfowl modified the milestones: 1.0.0-rc1, 1.0.0 Mar 5, 2015
@muratg muratg modified the milestones: 1.0.0, 1.0.0-beta5 Mar 20, 2015
@ChengTian
Copy link
Contributor

We should close the following issues after this is done:
#1788
#1816

@muratg
Copy link
Contributor

muratg commented May 8, 2015

#1816 (comment)

@muratg
Copy link
Contributor

muratg commented May 12, 2015

aspnet/Announcements#24

@troydai
Copy link
Contributor

troydai commented May 12, 2015

Fixed in f0a852a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants