Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Make "projects" in global.json accept project folder path directly #1841

Closed
ChengTian opened this issue May 11, 2015 · 5 comments
Closed

Make "projects" in global.json accept project folder path directly #1841

ChengTian opened this issue May 11, 2015 · 5 comments

Comments

@ChengTian
Copy link
Contributor

Today, each element in projects of global.json should be a parent folder of your projects.

For example, you have src/WebApplication5/project.json , then src should be added to projects , instead of src/WebApplication5. If you add src/WebApplication5 as an element in global.json, we are unable to resolve it.

However, it's actually quite intuitive that I should be able to add src/MyProject to projects in global.json (based on name of the property).

As @davidfowl suggests, we should measure the performance hit before doing it.

@glen-84
Copy link

glen-84 commented May 12, 2015

👍 How else would you reference a single project if src contains multiple projects?

@muratg muratg added this to the 1.0.0-beta5 milestone May 12, 2015
@ChengTian
Copy link
Contributor Author

@glen-84 , could you please give an example of the scenario you are talking about?

@glen-84
Copy link

glen-84 commented May 13, 2015

@ChengTian,

If src contains multiple projects, then all[*] of those projects are included, when I may just want to include one.

[*] For some reason, right now, it's including three of my projects and excluding MyProj.Tests.

@ChengTian
Copy link
Contributor Author

@glen-84 , thanks, I see your point. Yeah, with this change merged in, you will be able to add a specific project into global.json, without adding its peers.

@muratg
Copy link
Contributor

muratg commented May 22, 2015

Need to do some profiling and finish. Moving to beta6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants