Literal bit limit changed from 52 bits to 64 bits #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but causes test failures.
…n ASDF tree, as well as removed all tests associated with that limit.
eslavich
reviewed
Dec 8, 2020
more than 64 bits can be used in the ASDF tree.
…es to the validation to use these new constants, as well as the tests validating number sizes.
jdavies-st
approved these changes
Dec 11, 2020
…e it doesn't apply anymore.
|
What should we do about uint64 arrays that are small enough to be auto inlined? For example this: import numpy as np
import asdf
arr = np.array([2**64 - 1], dtype=np.uint64)
with asdf.AsdfFile({"arr": arr}) as af:
af.write_to("test.asdf")results in the following error: |
eslavich
reviewed
Dec 21, 2020
| @@ -401,24 +401,6 @@ def test_auto_inline_masked_array(tmpdir): | |||
| assert len(list(af.blocks.internal_blocks)) == 2 | |||
|
|
|||
|
|
|||
| def test_auto_inline_large_value(tmpdir): | |||
There was a problem hiding this comment.
Should we keep this test and rework it to cover the np.uint64 case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of the 52 bit limit for numbers in an ndarray (originally imposed for anticipated use with javascript), which allows usage for larger numbers. The
ndarrayis still limited by 64 bits by thedtype. In addition to removing this validation check, thepytesttests used to test the original limit have been removed as well.Resolves #891