Drop support for automatic serialization of subclass attributes #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslavich
force-pushed
the
eslavich-drop-subclass-attribute-serialization
branch
from
d0cf265
to
e3abc34
Compare
jdavies-st
reviewed
Jul 15, 2020
Since it still bears the tag associated with the parent class, then the parent class will be instantiated and the subclass attributes will be lost. That'd be pretty bad, but since the feature was marked experimental and I can't find any evidence of anyone using it, I don't think we need to worry too much about that case. |
jdavies-st
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bids farewell to the experimental feature that performed automatic serialization of subclass attributes.