Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of pathlib.Path objects for custom_schema option #663

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

drdavella
Copy link
Contributor

This fixes #653.

@drdavella drdavella added this to the v2.3.3 milestone Mar 18, 2019
@drdavella drdavella self-assigned this Mar 18, 2019
@stsci-bot
Copy link

stsci-bot bot commented Mar 18, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #663 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   93.24%   93.24%           
=======================================
  Files          39       39           
  Lines        4295     4295           
=======================================
  Hits         4005     4005           
  Misses        290      290
Impacted Files Coverage Δ
asdf/schema.py 94.16% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9dbdf1...7e392f7. Read the comment docs.

@drdavella drdavella merged commit 0c72145 into asdf-format:master Mar 18, 2019
@drdavella drdavella deleted the schema-pathlib branch March 18, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom_schema argument to open does not support pathlib.Path objects
1 participant