Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install schema tester plugin using entry points #657

Closed
drdavella opened this issue Mar 8, 2019 · 2 comments · Fixed by #676
Closed

Install schema tester plugin using entry points #657

drdavella opened this issue Mar 8, 2019 · 2 comments · Fixed by #676
Assignees

Comments

@drdavella
Copy link
Contributor

Also make its use opt-in, both with a command-line option and a configuration option.

@drdavella
Copy link
Contributor Author

Unfortunately this is going to lead to a bit of a discontinuity in compatible versions. This is because pytest will crash if a plugin is installed as an entry point and is also explicitly referenced in a project's conftest.py file. I can't seem to find a good way to provide a workaround either.

@drdavella
Copy link
Contributor Author

It turns out that packaging the plugin in this way is proving to be unreasonably burdensome. Doing it in a stable/reliable way would require moving the plugin to a separate package, which I think is not the way to go right now.

I am still in favor of making the plugin explicitly opt-in, however.

@asdf-format asdf-format deleted a comment from stscijgbot Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant