Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ignore_unrecognized_tag option to ASDF-in-FITS #650

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

drdavella
Copy link
Contributor

Previously this option was not being passed through when opening an ASDF-in-FITS file using the top-level API.

@drdavella drdavella added the bug label Feb 25, 2019
@drdavella drdavella added this to the v2.3.3 milestone Feb 25, 2019
@drdavella drdavella self-assigned this Feb 25, 2019
@stsci-bot
Copy link

stsci-bot bot commented Feb 25, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

2 similar comments
@stsci-bot
Copy link

stsci-bot bot commented Feb 25, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@stsci-bot
Copy link

stsci-bot bot commented Feb 25, 2019

Hi there @drdavella 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog. I help make sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #650   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          39       39           
  Lines        4287     4287           
=======================================
  Hits         3997     3997           
  Misses        290      290
Impacted Files Coverage Δ
asdf/asdf.py 94.25% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c576da...bb1ad91. Read the comment docs.

@drdavella drdavella merged commit d7c67a1 into asdf-format:master Feb 25, 2019
@drdavella drdavella deleted the unrecognized-tag branch February 25, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant