Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve tag references that use tag URI scheme #371

Merged
merged 3 commits into from
Nov 3, 2017
Merged

Resolve tag references that use tag URI scheme #371

merged 3 commits into from
Nov 3, 2017

Conversation

drdavella
Copy link
Contributor

This fixes #367 and allows tag references that use the tag URI scheme to be properly resolved in schema files.

@drdavella
Update test making sure full tag labels work in ASDF files
1feefa2
@drdavella
Add tests for loading schemas...
4b9e57e 
Currently it does not seem to work when a schema contains a fully
specified tag reference, which is highly unexpected.
@drdavella
Resolve tag references that use tag URI scheme
53a8de3
@drdavella drdavella added the bug label Oct 31, 2017
@drdavella drdavella added this to the 1.3.1 milestone Oct 31, 2017
@drdavella drdavella self-assigned this Oct 31, 2017
@drdavella drdavella requested a review from nden October 31, 2017 16:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.072% when pulling 53a8de3 on drdavella:tags-and-schemas into 6127e78 on spacetelescope:master.

@drdavella drdavella merged commit 12d91e5 into asdf-format:master Nov 3, 2017
@drdavella drdavella deleted the tags-and-schemas branch November 3, 2017 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden Awaiting requested review from nden

Assignees

@drdavella drdavella

Labels
bug
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

ASDF does not always properly resolve tag references in schema files
2 participants
@drdavella @coveralls