Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: drop importlib_metadata as a dependency on Python 3.12 and newer #1810

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Jul 24, 2024

This is a follow up to #1260: according to the comment linked in that PR's commit message, standard library importlib.metadata isn't problematic starting from Python 3.12

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@neutrinoceros neutrinoceros marked this pull request as ready for review July 24, 2024 16:55
@neutrinoceros neutrinoceros requested a review from a team as a code owner July 24, 2024 16:55
docs/conf.py Outdated Show resolved Hide resolved
@braingram
Copy link
Contributor

Thanks for the PR. I'll try to give this a test with weldx sometime soon.

Unfortunately the downstream testing in the CI will be insufficient to test this change (the possibly affected package, weldx, is being run with python 3.10).

Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set up a local python 3.12 environment, installed the source branch for this PR and weldx (I had to remove the upper pin they have for the python version). Running the script in the previous issue succeeded and I confirmed that in python 3.12 we no longer see duplicate entry points for the standard library importlib:

(EntryPoint(name='weldx', value='weldx.asdf.extension:get_extensions', group='asdf.extensions'),
 EntryPoint(name='asdf', value='asdf._core._integration:get_extensions', group='asdf.extensions'))

Thanks!

@braingram braingram merged commit c25d876 into asdf-format:main Jul 24, 2024
49 checks passed
@neutrinoceros neutrinoceros deleted the importlib_metadata branch July 24, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants