Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate options that control reading blocks #1548

Open
braingram opened this issue May 15, 2023 · 0 comments
Open

Consolidate options that control reading blocks #1548

braingram opened this issue May 15, 2023 · 0 comments

Comments

@braingram
Copy link
Contributor

AsdfFile.__init__ accepts:

  • lazy_load
  • copy_arrays

Whereas asdf.open accepts:

  • lazy_load
  • copy_arrays
  • validate_checksums

It is likely that lazy_load and copy_arrays make no sense outside of opening an existing AsdfFile. Combined with no public method to open a file using an existing AsdfFile instance it probably makes sense to move these into asdf.open or perhaps to consolidate these into a set of 'block access options'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant