Add asdf-unit-schemas as dependency #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
force-pushed
the
feature/unit
branch
from
0154bc4
to
2799ffe
Compare
WilliamJamieson
force-pushed
the
feature/unit
branch
from
2799ffe
to
139ef00
Compare
WilliamJamieson
requested review from
braingram,
eslavich and
perrygreenfield
|
Any clue why the |
Thats because they aren't being run anymore. I replaced them with a test matrix which runs the standard, transform, and unit tests. It only shows up because its marked as required currently. |
WilliamJamieson
commented
Oct 13, 2022
| asdf-standard: | ||
| name: Run asdf-standard tests | ||
| asdf-schemas: | ||
| name: ${{ matrix.package_name }}@${{ matrix.ref }} unit tests |
There was a problem hiding this comment.
This changes the name
|
Should this be merged then the requirements changed or the opposite? |
braingram
approved these changes
Oct 13, 2022
|
We cannot add the new CI as a requirement until this PR is merged. So we merge and then update the requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortly, we will drop
unitsfromasdf-standardin favor of theasdf-unit-schemas. For backwards compatibility reasons, we then need to addasdf-unit-schemasas a dependency toasdf.