-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace use of pkg_resources
with importlib
#1199
Replace use of pkg_resources
with importlib
#1199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good; should we also add importlib_metadata
to the build configuration as a dependency contingent on Python version?
We already are for other uses: Line 19 in d54afa2
|
25f6f58
to
bc3718b
Compare
Turns out I was wrong, we do have to add |
729df39
to
de1fb9c
Compare
Note "Required" needs to be updated after this is merged due to the CI job name changes. |
3ca175e
to
1a2dad2
Compare
1a2dad2
to
a58ec50
Compare
a58ec50
to
537dfd2
Compare
1bb14ab
to
af7c042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
af7c042
to
f954155
Compare
Replaces all uses of
pkg_resources
withimportlib
throughout asdf.Fixes #941