Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of pkg_resources with importlib #1199

Merged

Conversation

WilliamJamieson
Copy link
Contributor

Replaces all uses of pkg_resources with importlib throughout asdf.

Fixes #941

Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; should we also add importlib_metadata to the build configuration as a dependency contingent on Python version?

@WilliamJamieson
Copy link
Contributor Author

This looks good; should we also add importlib_metadata to the build configuration as a dependency contingent on Python version?

We already are for other uses:

'importlib_resources >=3; python_version <"3.9"',

@WilliamJamieson WilliamJamieson force-pushed the feature/remove-pkg_resources branch 3 times, most recently from 25f6f58 to bc3718b Compare September 27, 2022 16:18
@WilliamJamieson
Copy link
Contributor Author

This looks good; should we also add importlib_metadata to the build configuration as a dependency contingent on Python version?

Turns out I was wrong, we do have to add importlib-metadata as a dependency for python 3.9 or older. Why do they all have to be named similar things?

@WilliamJamieson WilliamJamieson force-pushed the feature/remove-pkg_resources branch 2 times, most recently from 729df39 to de1fb9c Compare September 27, 2022 17:00
@WilliamJamieson
Copy link
Contributor Author

Note "Required" needs to be updated after this is merged due to the CI job name changes.

@WilliamJamieson WilliamJamieson force-pushed the feature/remove-pkg_resources branch 2 times, most recently from 3ca175e to 1a2dad2 Compare October 4, 2022 15:04
Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@WilliamJamieson WilliamJamieson merged commit 920bf45 into asdf-format:master Oct 11, 2022
@WilliamJamieson WilliamJamieson deleted the feature/remove-pkg_resources branch October 11, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of pkg_resources with importlib.metadata
3 participants