Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove schema version parsing from the pytest plugin #1076

Merged

Conversation

eslavich
Copy link
Contributor

@eslavich eslavich commented Feb 7, 2022

This fixes a bug that causes the schema tests to fail when the schemas are not located in a directory named "schemas".

I'm also removing checks related to astropy 3.0 that are no longer relevant and changing the plugin to use the latest ASDF Standard version always, so that we don't need to worry about inferring the tag URI from the schema and parsing the version.

@eslavich eslavich added the bug label Feb 7, 2022
@eslavich eslavich added this to the 2.9.2 milestone Feb 7, 2022
Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 573b572 into asdf-format:master Feb 7, 2022
WilliamJamieson added a commit that referenced this pull request Feb 7, 2022
Remove schema version parsing from the pytest plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants