Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awrgo workflows chart doesn't add correct auth-mode argument to sever with sso.enabled=true #2281

Closed
alhimik45 opened this issue Sep 23, 2023 · 2 comments · Fixed by #2291
Closed

Awrgo workflows chart doesn't add correct auth-mode argument to sever with sso.enabled=true #2281

alhimik45 opened this issue Sep 23, 2023 · 2 comments · Fixed by #2291
Labels
argo-workflows enhancement New feature or request

Comments

@alhimik45
Copy link

Describe the bug

Setting server.sso.enabled: true and other sso params is not enough to enable SSO. It is needed to pass --auth-mode sso argument to server through server.extraArgs.

Related helm chart

argo-workflows

Helm chart version

0.33.3

To Reproduce

  1. Install chart with server.sso.enabled: true
  2. Open Argo Server UI
  3. Try to login through SSO
  4. Get blank screen with 501 http error

Expected behavior

Chart automatically adds --auth-mode sso to server params if SSO is enabled.

Screenshots

No response

Additional context

No response
@alhimik45 alhimik45 added the bug Something isn't working label Sep 23, 2023
@agilgur5 agilgur5 added enhancement New feature or request argo-workflows and removed bug Something isn't working labels Sep 23, 2023
@jmeridth
Copy link
Member

#2277 (comment)

@alhimik45
Copy link
Author

As I see, mention of auth mode in Readme was removed here

@yu-croco yu-croco mentioned this issue Oct 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
argo-workflows enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(argo-workflows): Configure declarative server auth mode yu-croco/argo-helm
3 participants
@jmeridth @alhimik45 @agilgur5