-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal does not work with windows containers #9951
Comments
I believe this is fixed in #9895, which will be released in 2.4.6. |
@EugeneLugovtsov I'm going to close the issue for now since it should be taken care of in #9895 if the bug persists, please reopen! |
@EugeneLugovtsov 2.4.6 was just released which includes #9895 , do you want to give it a try? |
@todaywasawesome yes, I have already given it a shot. I have the ability to type commands in ArgoCD v2.4.6. However, I can see that the terminal freezes sometimes, and the cursor is jumping around the terminal window |
I wonder if this is a race condition on the WriteMessage call. @EugeneLugovtsov if I wrote a patch, would you be able to build the image and test it? |
@crenshaw-dev yes, I can test it |
Can you give this a try? #9994 I'm sharing the read and write lock. It's possible we could get away with write having its own lock. |
(My suspicion is that this might solve the hanging issue but not the intermingled text issue.) |
@crenshaw-dev I have built the ArgoCD image from your branch. However, the terminal tab is missing now :( |
My bad @EugeneLugovtsov, I based that PR on master instead of release-2.4. Can you give this one a try? #10005 |
Gotcha, so shared read/write lock probably hurts performance and doesn't solve the problem. Are there any error logs in the browser (dev tools console or network traffic) or in the argocd-server? |
You mentioned it fails after ~1m. Is it possible there's a timeout on a reverse proxy? https://stackoverflow.com/a/57706152/684776 Maybe we should send the server a heartbeat: https://stackoverflow.com/a/57531353/684776 |
@crenshaw-dev sorry for the confusion, what I want to say: 10 times I tried to enable the terminal tab and 9 times the terminal did not work, and only once it started after ~ 1 min. |
Ah, okay. This is seeming environment-specific as @notfromstatefarm was not able to reproduce such consistently-broken behavior on a Windows container. |
Based on comments, appears individual environment specific. |
Did you find a resolution to the output glitch you describe? We have an environment with the same symptoms. |
Checklist:
argocd version
.Describe the bug
I can open the terminal tab and it successfully connects to the pod, but I cannot type anything in the terminal window.
To Reproduce
Expected behavior
The Terminal feature works for Linux and Windows based containers
Screenshots
Version
The text was updated successfully, but these errors were encountered: