Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External secrets values are not replaced in webhook settings #16261

Closed
3 tasks done
MrFreezeex opened this issue Nov 7, 2023 · 0 comments · Fixed by #16262
Closed
3 tasks done

External secrets values are not replaced in webhook settings #16261

MrFreezeex opened this issue Nov 7, 2023 · 0 comments · Fixed by #16262
Labels
bug Something isn't working

Comments

@MrFreezeex
Copy link
Contributor

MrFreezeex commented Nov 7, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

You can't reference other secrets in all the webhook settings with the the syntax $:.

To Reproduce

Have something like that:

apiVersion: v1
kind: Secret
stringData:
  webhook.github.secret: "mysecrethere"
metadata:
  labels:
    app.kubernetes.io/part-of: argocd
  name: argocd-helm-values
  namespace: argocd
type: Opaque

And set "webhook.github.secret" in "argocd-secret" to "$argocd-helm-values:webhook.github.secret". The value will not be replaced and you can check that by configuring the webhook with litterally "$argocd-helm-values:webhook.github.secret" (while any other value will not work meaning that the secret is not correctly replaced).

Expected behavior

The secret to be replaced

Screenshots

Version

Paste the output from `argocd version` here.

Logs

Paste any relevant application logs here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant