From c6be96b424f847b67fb6df5f9245bb36edd0b4bb Mon Sep 17 00:00:00 2001
From: Or Koren <or.koren@similarweb.com>
Date: Wed, 31 Jan 2024 21:38:36 +0200
Subject: [PATCH] fix(appset): keep reconcile even when params error occurred

Signed-off-by: Or Koren <or.koren@similarweb.com>
---
 applicationset/controllers/applicationset_controller.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/applicationset/controllers/applicationset_controller.go b/applicationset/controllers/applicationset_controller.go
index 4f5ac66fc016d..79eaf4cf5b7e0 100644
--- a/applicationset/controllers/applicationset_controller.go
+++ b/applicationset/controllers/applicationset_controller.go
@@ -135,7 +135,9 @@ func (r *ApplicationSetReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 				Status:  argov1alpha1.ApplicationSetConditionStatusTrue,
 			}, parametersGenerated,
 		)
-		return ctrl.Result{}, err
+		if len(desiredApplications) < 1 {
+			return ctrl.Result{}, err
+		}
 	}
 
 	parametersGenerated = true