From 3d5e9cb32afb14b9fa4220f4230f226e9b149fb0 Mon Sep 17 00:00:00 2001 From: phanama Date: Tue, 29 Aug 2023 23:55:23 +0700 Subject: [PATCH] fix: golangci lint return values not checked in tests --- util/cache/redis_hook_test.go | 6 ++++-- util/cache/redis_test.go | 18 ++++++++++++------ 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/util/cache/redis_hook_test.go b/util/cache/redis_hook_test.go index 05c04a0c1198b..4d7d9b7aaf41d 100644 --- a/util/cache/redis_hook_test.go +++ b/util/cache/redis_hook_test.go @@ -26,8 +26,9 @@ func Test_ReconnectCallbackHookCalled(t *testing.T) { faultyDNSRedisClient.AddHook(hook) faultyDNSClient := NewRedisCache(faultyDNSRedisClient, 60*time.Second, RedisCompressionNone) - faultyDNSClient.Set(&Item{Key: "baz", Object: "foo"}) + err = faultyDNSClient.Set(&Item{Key: "baz", Object: "foo"}) assert.Equal(t, called, true) + assert.Error(t, err) } func Test_ReconnectCallbackHookNotCalled(t *testing.T) { @@ -46,6 +47,7 @@ func Test_ReconnectCallbackHookNotCalled(t *testing.T) { redisClient.AddHook(hook) client := NewRedisCache(redisClient, 60*time.Second, RedisCompressionNone) - client.Set(&Item{Key: "foo", Object: "bar"}) + err = client.Set(&Item{Key: "foo", Object: "bar"}) assert.Equal(t, called, false) + assert.NoError(t, err) } diff --git a/util/cache/redis_test.go b/util/cache/redis_test.go index 3432e03899a76..e05c7541f5ff1 100644 --- a/util/cache/redis_test.go +++ b/util/cache/redis_test.go @@ -135,24 +135,30 @@ func TestRedisMetrics(t *testing.T) { var res string //client successful request - client.Set(&Item{Key: "foo", Object: "bar"}) - client.Get("foo", &res) + err = client.Set(&Item{Key: "foo", Object: "bar"}) + assert.NoError(t, err) + err = client.Get("foo", &res) + assert.NoError(t, err) c, err := ms.redisRequestCounter.GetMetricWithLabelValues("mock", "false") - c.Write(metric) + assert.NoError(t, err) + err = c.Write(metric) assert.NoError(t, err) assert.Equal(t, metric.Counter.GetValue(), float64(2)) //faulty client failed request - faultyClient.Get("foo", &res) + err = faultyClient.Get("foo", &res) + assert.Error(t, err) c, err = ms.redisRequestCounter.GetMetricWithLabelValues("mock", "true") - c.Write(metric) + assert.NoError(t, err) + err = c.Write(metric) assert.NoError(t, err) assert.Equal(t, metric.Counter.GetValue(), float64(1)) //both clients histogram count o, err := ms.redisRequestHistogram.GetMetricWithLabelValues("mock") - o.(prometheus.Metric).Write(metric) + assert.NoError(t, err) + err = o.(prometheus.Metric).Write(metric) assert.NoError(t, err) assert.Equal(t, int(metric.Histogram.GetSampleCount()), 3) }