Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Does anyone know where the reference to @types/node is coming from #851

Closed
jimisaacs opened this issue Feb 19, 2021 · 1 comment
Closed

Comments

@jimisaacs
Copy link

jimisaacs commented Feb 19, 2021

In the latest published version of this package of 0.9.18: https://registry.npmjs.com/subscriptions-transport-ws/-/subscriptions-transport-ws-0.9.18.tgz

In dist/server.d.ts, you can see this right at the top:

/// <reference types="node" />

Though how is it getting there? I don't see it anywhere in the sources within this repo.

This is causing the node types to leak into our projects based on this issue:
microsoft/TypeScript#31148 (comment)

I've also already commented on this package here:
apollographql/apollo-client#7734

Though I'm confused and would like some clarification.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants