-
+
{!isInitialized ? (
@@ -380,11 +375,26 @@ const FilterBar: React.FC = ({
filterSetId={editFilterSetId}
/>
)}
-
+ {filterValues.length === 0 ? (
+
+
+
+ ) : (
+
+ )}
= ({
image="filter.svg"
description={
canEdit &&
- t(
- 'Click the pencil icon above to add a filter to the dashboard',
- )
+ t('Click the button above to add a filter to the dashboard')
}
/>
@@ -427,6 +435,13 @@ const FilterBar: React.FC = ({
)}
)}
+
);
diff --git a/superset-frontend/src/dashboard/constants.ts b/superset-frontend/src/dashboard/constants.ts
index ab3fa29a0b773..169a2d09de192 100644
--- a/superset-frontend/src/dashboard/constants.ts
+++ b/superset-frontend/src/dashboard/constants.ts
@@ -33,3 +33,12 @@ export const PLACEHOLDER_DATASOURCE: Datasource = {
main_dttm_col: '',
description: '',
};
+
+export const MAIN_HEADER_HEIGHT = 53;
+export const TABS_HEIGHT = 50;
+export const HEADER_HEIGHT = 72;
+export const CLOSED_FILTER_BAR_WIDTH = 32;
+export const OPEN_FILTER_BAR_WIDTH = 260;
+export const FILTER_BAR_HEADER_HEIGHT = 80;
+export const FILTER_BAR_TABS_HEIGHT = 46;
+export const BUILDER_SIDEPANEL_WIDTH = 374;
diff --git a/superset-frontend/src/utils/common.js b/superset-frontend/src/utils/common.js
index 26fdfb4bd6e44..4efdb205e5a9f 100644
--- a/superset-frontend/src/utils/common.js
+++ b/superset-frontend/src/utils/common.js
@@ -144,3 +144,5 @@ export const detectOS = () => {
return 'Unknown OS';
};
+
+export const isNullish = value => value === null || value === undefined;