From 413e02443aa940c5b37a43e67d24264aee4ed964 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 10 Jan 2022 12:06:46 -0800 Subject: [PATCH 1/2] fix: full screen mode for dashboard --- .../dashboard/components/Header/HeaderActionsDropdown/index.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx index 77dd5211c75b6..ff3cabbf04b57 100644 --- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx +++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx @@ -148,6 +148,7 @@ class HeaderActionsDropdown extends React.PureComponent { } handleMenuClick({ key, domEvent }) { + console.log('hello i hit in menu click') switch (key) { case MENU_KEYS.REFRESH_DASHBOARD: this.props.forceRefreshAllCharts(); @@ -174,7 +175,6 @@ class HeaderActionsDropdown extends React.PureComponent { } case MENU_KEYS.TOGGLE_FULLSCREEN: { const url = getDashboardUrl({ - dataMask: this.props.dataMask, pathname: window.location.pathname, filters: getActiveFilters(), hash: window.location.hash, From 30d878b6a4e780bdab2426ec3a2aaa20e9d171a2 Mon Sep 17 00:00:00 2001 From: Phillip Kelley-Dotson Date: Mon, 10 Jan 2022 12:14:18 -0800 Subject: [PATCH 2/2] remove console --- .../dashboard/components/Header/HeaderActionsDropdown/index.jsx | 1 - 1 file changed, 1 deletion(-) diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx index ff3cabbf04b57..a7cb30218de39 100644 --- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx +++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx @@ -148,7 +148,6 @@ class HeaderActionsDropdown extends React.PureComponent { } handleMenuClick({ key, domEvent }) { - console.log('hello i hit in menu click') switch (key) { case MENU_KEYS.REFRESH_DASHBOARD: this.props.forceRefreshAllCharts();