From 15a030e146106267bd4170819e672180aec772ca Mon Sep 17 00:00:00 2001 From: rasta-rocket Date: Fri, 16 Apr 2021 17:50:08 +0200 Subject: [PATCH 1/2] fix(views/core): iteration over None type --- superset/views/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/views/core.py b/superset/views/core.py index b8e47920428c6..20ec631fbf125 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -959,7 +959,7 @@ def save_or_overwrite_slice( slc = Slice(owners=[g.user] if g.user else []) form_data["adhoc_filters"] = self.remove_extra_filters( - form_data.get("adhoc_filters", []) + (form_data.get("adhoc_filters", []) or []) ) assert slc From 547e80b2136264c42634415ef05f65d4460bcdbd Mon Sep 17 00:00:00 2001 From: rasta-rocket Date: Wed, 17 Nov 2021 10:02:06 +0100 Subject: [PATCH 2/2] fix(views/core): apply suggestion --- superset/views/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/views/core.py b/superset/views/core.py index 20ec631fbf125..38a791319bf3c 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -959,7 +959,7 @@ def save_or_overwrite_slice( slc = Slice(owners=[g.user] if g.user else []) form_data["adhoc_filters"] = self.remove_extra_filters( - (form_data.get("adhoc_filters", []) or []) + form_data.get("adhoc_filters") or [] ) assert slc