-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load CSV from backend storage (GCS) #8546
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
Thank you for opening the SIP - I'd love to understand the usecase better here. What is the motivation for adding the ability to load CSVs from cloud locations? What user behavior are you trying to support. Thanks! |
If it fits in a few lines it probably does not require the formal SIP process. I think we should completely rebuild the CSV uploader in React. |
Use case is basic, in a corporante environnement, team would share a CSV on a backend storage and then could be analyzed using SuperSet without getting the data out of cloud... Does it make sense ? |
Yes, that makes sense @YannBrrd. Go for it. Be aware that this system is going to be rebuilt from scratch at some point in the near future, so please attempt to make your addition modular and loosely coupled. That will help us avoid redoing your work when we migrate the feature. |
I've been looking at how you connect to BigQuery. It is an application level access if I got it well. Might not it be better/an option to have OAuth2 ? Doing this, I'd inherit accesses for current user... |
Adding an option for OAuth2 connections to BigQuery would be a great addition. It might be worth a SIP to investigate the approach before moving forward. I do know some organizations have been able to use a service account and impersonation to achieve the same access controls. |
Once done for BQ it will be basic for GCS. Have access rto the method others used? |
@YannBrrd unfortunately that code is closed-source, so I cannot share it. |
Fair enough. I'm drowning in Google Python APIs. 😃 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
[SIP] Proposal to add a 'Load CSV from...' feature
Motivation
Providing a way to load CSV from different storages (first in my mind is GCS).
Proposed Change
On top of providing a way to load CSV from user interface, allow to load a file from a backend storage such as GCS or other backends from cloud providers
New or Changed Public Interfaces
Adding a 'Load CSV from...' button
New dependencies
I'd tend to use libcloud, from Apache.
Migration Plan and Compatibility
None
Rejected Alternatives
None, AFAIK.
The text was updated successfully, but these errors were encountered: