Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Lab query limit too large to handle default settings #5390

Closed
3 tasks done
villebro opened this issue Jul 13, 2018 · 0 comments · Fixed by #5392
Closed
3 tasks done

SQL Lab query limit too large to handle default settings #5390

villebro opened this issue Jul 13, 2018 · 0 comments · Fixed by #5392

Comments

@villebro
Copy link
Member

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

master

Expected results

When submitting a query via SQL Lab, the query should only display a sensible amount of rows, e.g. the default value of DISPLAY_SQL_MAX_ROW (set to 1,000 in config.py).

Actual results

The query is limited to SQL_MAX_ROW (set to 1,000,000 in config.py), which causes unnecessary strain on the datasource and crashes the browser on large tables.

Steps to reproduce

  1. Open SQL Lab
  2. Write query against big table
  3. Wait for browser to crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant