Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for file could be the same for superset export-dashboards / superset import-dashboards #28690

Open
3 tasks
xavier-GitHub76 opened this issue May 24, 2024 · 0 comments
Assignees
Labels
change:backend Requires changing the backend change:frontend Requires changing the frontend

Comments

@xavier-GitHub76
Copy link
Contributor

Bug description

Hello,
Option for file could be the same for superset export-dashboards / superset import-dashboards

Actually :

  • export-dashboards use : -f
  • import-dashboards use : -p

In https://github.com/apache/superset/blob/master/superset/cli/importexport.py
"-f" is used to define a file for :
export_dashboards :
image

export_datasources :
image

(and 2 legacy :

  • legacy_export_dashboards
  • legacy_export_datasources
    )

"-p" is used to define a file for :
import_dashboards
image

import_datasources
image

(and 4 legacy :

  • legacy_export_dashboards
  • legacy_export_datasources
  • legacy_import_dashboards
  • legacy_import_datasources
    )

"-p" should be used everywhere, like superset fab export-roles

image

Best regards

How to reproduce the bug

superset export-dashboards --help

Usage: superset export-dashboards [OPTIONS]

Export dashboards to ZIP file

Options:
-f, --dashboard-file TEXT Specify the file to export to
--help Show this message and exit.

superset import-dashboards --help
Usage: superset import-dashboards [OPTIONS]

Import dashboards from ZIP file

Options:
-p, --path TEXT Path to a single ZIP file [required]
-u, --username TEXT Specify the user name to assign dashboards to
[required]
--help Show this message and exit.

Screenshots/recordings

No response

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@dosubot dosubot bot added change:backend Requires changing the backend change:frontend Requires changing the frontend labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:backend Requires changing the backend change:frontend Requires changing the frontend
Projects
None yet
Development

No branches or pull requests

2 participants