Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Sets the DRILL_BY feature flag to True by default #26637

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

As part of the 4.0 approved initiatives, this PR sets the DRILL_BY feature flag to True by default given that the feature has been tested for a while and reached a stable state.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team January 16, 2024 16:26
@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Jan 16, 2024
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ca6d8c) 69.18% compared to head (33dfc6f) 69.04%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26637      +/-   ##
==========================================
- Coverage   69.18%   69.04%   -0.14%     
==========================================
  Files        1948     1938      -10     
  Lines       76036    75609     -427     
  Branches     8478     8478              
==========================================
- Hits        52604    52205     -399     
+ Misses      21265    21237      -28     
  Partials     2167     2167              
Flag Coverage Δ
hive 53.58% <ø> (-0.11%) ⬇️
mysql 77.86% <ø> (-0.19%) ⬇️
postgres 77.98% <ø> (-0.19%) ⬇️
presto 53.53% <ø> (-0.11%) ⬇️
python 82.73% <ø> (-0.13%) ⬇️
sqlite 77.57% <ø> (-0.19%) ⬇️
unit 55.81% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-s-molina michael-s-molina merged commit 902dafd into apache:master Jan 17, 2024
34 checks passed
Muhammed-baban pushed a commit to intellica-tech/reporting-tool that referenced this pull request Jan 19, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants