Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last date/time label missing on chart X axis #25099

Open
dennishwuh opened this issue Aug 28, 2023 · 7 comments
Open

Last date/time label missing on chart X axis #25099

dennishwuh opened this issue Aug 28, 2023 · 7 comments
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@dennishwuh
Copy link

dennishwuh commented Aug 28, 2023

Hi, I managed to run a superset docker, connected to my own database and plotted some charts successfully.
However, it didn't show up the last day in X axis, has anybody faced the same problem, please help.
Thanks for your time.

Screenshots

superset

Environment

Docker

@sfirke sfirke changed the title Superset didn't show the last day of data in X axis Last date/time label missing on chart X axis Aug 28, 2023
@sfirke
Copy link
Member

sfirke commented Aug 28, 2023

This bug was patched in #20627 in summer 2022, there was no original bug report issue I found so thank you for creating this. That patch was reverted in August 2023 because it had caused a worse problem of a strangely-formatted final datetime label. So this bug is open again and will likely be present in 2.1.1 and 3.0.0.

Those interested in patching this should see discussions on those two PRs.

@sfirke sfirke added the validation:validated A committer has validated / submitted the issue or it was reported by multiple users label Aug 28, 2023
@rusackas
Copy link
Member

rusackas commented Mar 8, 2024

I've seen issues that are almost to the contrary of this, where people wanted the end-of-axis tick removed because it didn't match the granularity of the other ticks. E.g. the ticks would be Jan, Feb, Mar, 3/14/23. Do you think this ist still an issue to contend with @sfirke ?

@liany-dropit
Copy link

I'm also having this issue:
image

@sfirke
Copy link
Member

sfirke commented Jul 25, 2024

@liany-dropit am I correct that the line in that chart extends beyond Sunday, so there should be a Sunday label?

@rusackas from looking at Antonio's before/after in the original PR, I believe what the PR was fixing was the case where there is one more complete time period label that is missing. His "after" video cuts off quickly but I think it shows a "May" value populating.

I agree that Jan, Feb, Mar, 3/14/23 is bad, that's why the PR got reverted. But I believe the complaint is that without the PR it's going Jan, Feb, <> and the March value is unlabeled -- Jan, Feb, Mar would be the correct behavior. Caveat: I don't have an example of this bug at hand so am going from screenshots/video/memory.

@liany-dropit
Copy link

liany-dropit commented Aug 12, 2024

@sfirke In this case this is a weekly chart, it should show a full week, so Sunday is the last item in this chart. I expect there to be a label for Sunday as it looks strange that it's the only one of the seven days that doesn't have a label but does have a value.
image

@liany-dropit
Copy link

@sfirke do you have an estimation for a fix on this issue?

@sfirke
Copy link
Member

sfirke commented Oct 8, 2024

No idea sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

No branches or pull requests

4 participants