Tests fail for optional prophet forecasting functionality

[sebastianliebscher]

Without the installed prophet python package, the integration tests for prophet forecasting functionality (introduced in #10324) will be skipped. After installing the optional dependency [prophet] their tests will run but fail.
Upgrading to latest prophet version does not fix the issue.

How to reproduce the bug

• pip install "prophet>=1.0.1, <1.1" "pystan<3.0"
• scripts/tests/run.sh --module tests/integration_tests/charts/data/api_tests.py

Expected results

integration tests pass

Actual results

======================================================================================================================= FAILURES =======================================================================================================================
_____________________________________________________________________________________________________ TestPostChartDataApi.test_chart_data_prophet _____________________________________________________________________________________________________

self = <tests.integration_tests.charts.data.api_tests.TestPostChartDataApi testMethod=test_chart_data_prophet>

    def test_chart_data_prophet(self):
        """
        Chart data API: Ensure prophet post transformation works
        """
        pytest.importorskip("prophet")
        time_grain = "P1Y"
        self.query_context_payload["queries"][0]["is_timeseries"] = True
        self.query_context_payload["queries"][0]["groupby"] = []
        self.query_context_payload["queries"][0]["extras"] = {
            "time_grain_sqla": time_grain
        }
        self.query_context_payload["queries"][0]["granularity"] = "ds"
        self.query_context_payload["queries"][0]["post_processing"] = [
            {
                "operation": "prophet",
                "options": {
                    "time_grain": time_grain,
                    "periods": 3,
                    "confidence_interval": 0.9,
                },
            }
        ]
        rv = self.post_assert_metric(CHART_DATA_URI, self.query_context_payload, "data")
>       self.assertEqual(rv.status_code, 200)
E       AssertionError: 400 != 200

tests/integration_tests/charts/data/api_tests.py:470: AssertionError

=============================================================================================================== short test summary info ================================================================================================================
FAILED tests/integration_tests/charts/data/api_tests.py::TestPostChartDataApi::test_chart_data_prophet - AssertionError: 400 != 200
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
================================================================================================ 1 failed, 8 passed, 1 skipped, 6558 warnings in 13.50s ================================================================================================

Environment

• superset version: latest master
• python version: 3.9

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

[michael-s-molina]

@john-bodley Can we close this issue given #24129?