Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm installation uses latest tag by default #17540

Closed
alexander-onesoil opened this issue Nov 24, 2021 · 9 comments
Closed

Helm installation uses latest tag by default #17540

alexander-onesoil opened this issue Nov 24, 2021 · 9 comments
Labels
#bug Bug report

Comments

@alexander-onesoil
Copy link

Using latest tag in helm releases is really dangerous story. I've faced the issue today, because new latest tag expects to have 'dashboards.certifiedBy" column in the table which leads to dashboards fetching error.
It's much more better to manage app version tag using standard helm approach.

How to reproduce the bug

  1. Install helm release (current version)
  2. Go to superset UI
  3. Will have issue

Expected results

Works

Actual results

Dashboards fetching fails

Screenshots

If applicable, add screenshots to help explain your problem.
image

sqlalchemy.exc.ProgrammingError: (psycopg2.errors.UndefinedColumn) column dashboards.certified_by does not exist
LINE 2: ..._position_json, dashboards.css AS dashboards_css, dashboards...
                                                             ^

[SQL: SELECT count(*) AS count_1
@alexander-onesoil alexander-onesoil added the #bug Bug report label Nov 24, 2021
@quenchua
Copy link

Yes, this is an issue we faced as well. I noticed that the Superset version was frequently getting updated whenever the pods restarted.
We have now uploaded an image to ECR and pull from there each time.

@CarpathianUA
Copy link

Expiriencing the same

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@CarpathianUA
Copy link

It's still actual

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 29, 2022
@vparmeland
Copy link

Same issue with ECS Setup (upgrade to 1.5.0)

@Noamstrauss
Copy link

Noamstrauss commented Aug 9, 2022

Experiencing the same issue

@cberge908
Copy link

Is this still recent? At least by looking at the current helm templates it should default to the appVersion of the chart:

image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"

@sfirke
Copy link
Member

sfirke commented Sep 6, 2023

Can anyone confirm if this is still a current issue?

@sfirke
Copy link
Member

sfirke commented Feb 9, 2024

Looks like @cberge908 is correct, there's the line he linked to which points to appVersion here, that gets bumped manually but consistently after official releases: https://github.com/apache/superset/blob/master/helm/superset/Chart.yaml#L18

Currently 3.1.0. I'm going to close this as fixed.

@sfirke sfirke closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

7 participants