Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard SPA refactor broke basic functionality #14094

Closed
2 of 3 tasks
amitmiran137 opened this issue Apr 13, 2021 · 1 comment · Fixed by #14099
Closed
2 of 3 tasks

Dashboard SPA refactor broke basic functionality #14094

amitmiran137 opened this issue Apr 13, 2021 · 1 comment · Fixed by #14099
Assignees
Labels
#bug Bug report SPA

Comments

@amitmiran137
Copy link
Member

The dashboard used to hide menu items for the dashboard and charts when removing permissions from your role like:
can_csv
can_explore
this stopped working after #13306 was merged

I believe that the new HYDRATE_DASHBOARD action doesn't propagate as it should

Expected results

permissions should effect menu items visibility

Actual results

permissions should doesn't effect menu items visibility

Screenshots

permissions_failed_to_enforce.mov

How to reproduce the bug

  1. Go to Admin role
  2. remove can csv on superset and can explore on superset
  3. go to a dashboard and refresh the page
  4. check out for the menu items of explore and csv

Environment

(please complete the following information):

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@suddjian
Copy link
Member

Thank you for catching this, and for the quick fix! Reviewing the PR first thing today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report SPA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants