Data not aligned (bad choice of font)

[squalou]

Screenshot

Using Superset 1.0.1

Here for dates fields :

Here for some prices

Description

When analysing data in a table, one expects them to be nicely aligned.

It's especially the case regarding money amounts.

Fonts should be monospace.

[mohansaimandalapu]

Hi squalou

I am interested in solving this issue, this is my first PR, can you explain how to solve this issue. Thank you

[squalou]

I did an ugly fix on my side, and it's probably NOT the way to go, nevertheless here's what I did.

in file superset-frontend/stylesheets/less/variables.less I removed 'Inter' font entirely

< @font-family-sans-serif: 'Inter', Helvetica, Arial;
---
> @font-family-sans-serif: Helvetica, Arial;

it works but ... it has effects everywhere. (which is fine on my setup)

[squalou]

Are there any update ?
I'm testing 1.2.0-rc2 with my patch, would be glad to get rid of it.

[rajpratyush]

can i take this issue up?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[rusackas]

@geido I think you took a look at this quite some time ago using the monospaced variant of Inter. Do you remember where that landed? I seem to recall the difficulty being around knowing/mapping which columns to which we should apply the styling/class

[geido]

@rusackas the fix was applied to the table in this PR #19668. There's probably more work to do to make sure this works fine everywhere but as far as I remember it should look good now in most places.

[rusackas]

Ok, closing this for now then... @squalou please feel free to open a fresh issue with updated specifics if we need to investigate this further! Thank you!

[squalou]

Great news of sort :)
Is there an easy way to know in which release this PR has landed ? (if it has already).

I remember trying 2.0.1-rc1 last October, it was not yet right.

[squalou]

I'll sadly have to open a fresh issue,
here is a 2.0.1 table with dates