Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart] New chart data API should format errors according to SIP-40 #11882

Closed
robdiciuccio opened this issue Dec 1, 2020 · 1 comment
Closed
Labels
enhancement:request Enhancement request submitted by anyone from the community global:error Related to global errors affecting the platform

Comments

@robdiciuccio
Copy link
Member

Currently, requests to /api/v1/chart/data return an error response in the following format:

{ message: "error message text here" }

Error responses should be formatted according to SIP-40 in order to enable rich error reporting for charts in the frontend.

Example of chart error reporting with legacy (/superset/explore_json) chart requests:
Screen Shot 2020-12-01 at 3 54 43 PM
Screen Shot 2020-12-01 at 3 54 50 PM

Example of chart error reporting with new (/api/v1/chart/data) chart requests:
Screen Shot 2020-12-01 at 3 54 57 PM
Screen Shot 2020-12-01 at 3 55 19 PM

Additional context

@robdiciuccio robdiciuccio added the enhancement:request Enhancement request submitted by anyone from the community label Dec 1, 2020
@junlincc junlincc added global:error Related to global errors affecting the platform and removed preset-io labels Dec 2, 2020
@nytai
Copy link
Member

nytai commented Apr 21, 2021

this seems resolved by #14040 please reopen if it's not the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community global:error Related to global errors affecting the platform
Projects
None yet
Development

No branches or pull requests

3 participants