From c563ea091e03384c07ef518b3df8c7eef0d455a0 Mon Sep 17 00:00:00 2001 From: "Hugh A. Miles II" Date: Mon, 12 Apr 2021 16:45:50 -0400 Subject: [PATCH] fix: flacky test in test_update_dataset_item_w_override_columns (#14082) * fix flack test * fix flack test --- tests/datasets/api_tests.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tests/datasets/api_tests.py b/tests/datasets/api_tests.py index 9410e533bbb86..b82ef75d41499 100644 --- a/tests/datasets/api_tests.py +++ b/tests/datasets/api_tests.py @@ -582,16 +582,15 @@ def test_update_dataset_item_w_override_columns(self): # Add default dataset dataset = self.insert_default_dataset() self.login(username="admin") + new_col_dict = { + "column_name": "new_col", + "description": "description", + "expression": "expression", + "type": "INTEGER", + "verbose_name": "New Col", + } dataset_data = { - "columns": [ - { - "column_name": "new_col", - "description": "description", - "expression": "expression", - "type": "INTEGER", - "verbose_name": "New Col", - } - ], + "columns": [new_col_dict], "description": "changed description", } uri = f"api/v1/dataset/{dataset.id}?override_columns=true" @@ -600,10 +599,10 @@ def test_update_dataset_item_w_override_columns(self): columns = db.session.query(TableColumn).filter_by(table_id=dataset.id).all() - assert columns[0].column_name == dataset_data["columns"][0]["column_name"] - assert columns[0].description == dataset_data["columns"][0]["description"] - assert columns[0].expression == dataset_data["columns"][0]["expression"] - assert columns[0].type == dataset_data["columns"][0]["type"] + assert new_col_dict["column_name"] in [col.column_name for col in columns] + assert new_col_dict["description"] in [col.description for col in columns] + assert new_col_dict["expression"] in [col.expression for col in columns] + assert new_col_dict["type"] in [col.type for col in columns] db.session.delete(dataset) db.session.commit()