From 0cdc7675b401eeb82af77ab4192ec4b90f14f794 Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Mon, 23 Aug 2021 15:38:53 -0300 Subject: [PATCH] chore: Displays the dataset description in a tooltip in the datasets list (#16392) --- superset-frontend/src/components/InfoTooltip/index.tsx | 10 +++++++++- .../src/views/CRUD/data/dataset/DatasetList.tsx | 5 +++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/superset-frontend/src/components/InfoTooltip/index.tsx b/superset-frontend/src/components/InfoTooltip/index.tsx index 968f5df715980..e27c3729a4e92 100644 --- a/superset-frontend/src/components/InfoTooltip/index.tsx +++ b/superset-frontend/src/components/InfoTooltip/index.tsx @@ -52,6 +52,14 @@ const StyledTooltip = styled(Tooltip)` } `; +const StyledTooltipTitle = styled.span` + display: -webkit-box; + -webkit-line-clamp: 20; + -webkit-box-orient: vertical; + overflow: hidden; + text-overflow: ellipsis; +`; + const defaultOverlayStyle = { fontSize: '12px', lineHeight: '16px', @@ -69,7 +77,7 @@ export default function InfoTooltip({ }: InfoTooltipProps) { return ( {tooltip}} placement={placement} trigger={trigger} overlayStyle={overlayStyle} diff --git a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx index 15a00969961ba..496decf71e774 100644 --- a/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx +++ b/superset-frontend/src/views/CRUD/data/dataset/DatasetList.tsx @@ -51,6 +51,7 @@ import { Tooltip } from 'src/components/Tooltip'; import Icons from 'src/components/Icons'; import FacePile from 'src/components/FacePile'; import CertifiedIcon from 'src/components/CertifiedIcon'; +import InfoTooltip from 'src/components/InfoTooltip'; import ImportModelsModal from 'src/components/ImportModal/index'; import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags'; import WarningIconWithTooltip from 'src/components/WarningIconWithTooltip'; @@ -228,6 +229,7 @@ const DatasetList: FunctionComponent = ({ original: { extra, table_name: datasetTitle, + description, explore_url: exploreURL, }, }, @@ -249,6 +251,9 @@ const DatasetList: FunctionComponent = ({ /> )} {titleLink} + {description && ( + + )} ); } catch {