Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ConfigOption add sinceVersion #4188

Open
1 of 2 tasks
melin opened this issue Sep 14, 2024 · 2 comments
Open
1 of 2 tasks

[Feature] ConfigOption add sinceVersion #4188

melin opened this issue Sep 14, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@melin
Copy link
Contributor

melin commented Sep 14, 2024

Search before asking

  • I searched in the issues and found nothing similar.

Motivation

ConfigOption add the sinceVersion. Records from which version the parameter was added

Solution

No response

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@melin melin added the enhancement New feature or request label Sep 14, 2024
@JingsongLi
Copy link
Contributor

Good point!

@davedwwang
Copy link

Good point!

This issue seems to be more friendly to newcomers, can I give it a try? I understand that we can refer to the implementation of Spark:

  1. Add a private field version to ConfigOption.
  2. Add a public method sinceVersion to ConfigOption.
  3. Sort out all created ConfigOptions to find out which version the ConfigOption was introduced from. The involved classes are CoreOptions, CatalogOptions, SecurityConfiguration, AbstractIcebergCommitCallback, RocksDBOptions, PrivilegedCatalog, FlinkCatalogOptions, AvroFileFormat, and HiveCatalogOptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants